summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Transforms/IPO/MergeFunctions.cpp
diff options
context:
space:
mode:
authorNick Lewycky <nicholas@mxc.ca>2011-01-27 08:38:19 +0000
committerNick Lewycky <nicholas@mxc.ca>2011-01-27 08:38:19 +0000
commit13e04aef2ae496acb73020461d22ad593b78cf9b (patch)
tree29d4e4ce2950a2ec9b8cdae87bd046608869bc42 /llvm/lib/Transforms/IPO/MergeFunctions.cpp
parentd5c9b1d65e4be93d24bb8304107bf42104bbe46d (diff)
downloadbcm5719-llvm-13e04aef2ae496acb73020461d22ad593b78cf9b.tar.gz
bcm5719-llvm-13e04aef2ae496acb73020461d22ad593b78cf9b.zip
Fix surprising missed optimization in mergefunc where we forgot to consider
that relationships like "i8* null" is equivalent to "i32* null". llvm-svn: 124368
Diffstat (limited to 'llvm/lib/Transforms/IPO/MergeFunctions.cpp')
-rw-r--r--llvm/lib/Transforms/IPO/MergeFunctions.cpp15
1 files changed, 12 insertions, 3 deletions
diff --git a/llvm/lib/Transforms/IPO/MergeFunctions.cpp b/llvm/lib/Transforms/IPO/MergeFunctions.cpp
index 1e328ca6819..fb55d7ce4f0 100644
--- a/llvm/lib/Transforms/IPO/MergeFunctions.cpp
+++ b/llvm/lib/Transforms/IPO/MergeFunctions.cpp
@@ -460,9 +460,18 @@ bool FunctionComparator::Enumerate(const Value *V1, const Value *V2) {
if (V1 == F2 && V2 == F1)
return true;
- // TODO: constant expressions with GEP or references to F1 or F2.
- if (isa<Constant>(V1))
- return V1 == V2;
+ if (isa<Constant>(V1)) {
+ if (V1 == V2) return true;
+ const Constant *C1 = cast<Constant>(V1);
+ const Constant *C2 = dyn_cast<Constant>(V2);
+ if (!C2) return false;
+ // TODO: constant expressions with GEP or references to F1 or F2.
+ if (C1->isNullValue() && C2->isNullValue() &&
+ isEquivalentType(C1->getType(), C2->getType()))
+ return true;
+ return C1->getType()->canLosslesslyBitCastTo(C2->getType()) &&
+ C1 == ConstantExpr::getBitCast(const_cast<Constant*>(C2), C1->getType());
+ }
if (isa<InlineAsm>(V1) && isa<InlineAsm>(V2)) {
const InlineAsm *IA1 = cast<InlineAsm>(V1);
OpenPOWER on IntegriCloud