diff options
| author | Piotr Padlewski <piotr.padlewski@gmail.com> | 2016-08-11 22:13:57 +0000 |
|---|---|---|
| committer | Piotr Padlewski <piotr.padlewski@gmail.com> | 2016-08-11 22:13:57 +0000 |
| commit | 332b3b22109e9c0d84456888150c0a30f378f984 (patch) | |
| tree | 777b39aba73791c52ead7d1c4a2e785441b0c86c /llvm/lib/Transforms/IPO/FunctionImport.cpp | |
| parent | 6daefcf6262299a4233231c49b9048c1062dbc90 (diff) | |
| download | bcm5719-llvm-332b3b22109e9c0d84456888150c0a30f378f984.tar.gz bcm5719-llvm-332b3b22109e9c0d84456888150c0a30f378f984.zip | |
Don't import variadic functions
Summary:
This patch adds IsVariadicFunction bit to summary in order
to not import variadic functions. Inliner doesn't inline
variadic functions because it is hard to reason about it.
This one small fix improves Importer by about 16%
(going from 86% to 100% of imported functions that are
inlined anywhere)
on some spec benchmarks like 'int' and others.
Reviewers: eraman, mehdi_amini, tejohnson
Subscribers: mehdi_amini, llvm-commits
Differential Revision: https://reviews.llvm.org/D23339
llvm-svn: 278432
Diffstat (limited to 'llvm/lib/Transforms/IPO/FunctionImport.cpp')
| -rw-r--r-- | llvm/lib/Transforms/IPO/FunctionImport.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp index 7446a7d0f47..c9d008ebd38 100644 --- a/llvm/lib/Transforms/IPO/FunctionImport.cpp +++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp @@ -130,6 +130,10 @@ static bool eligibleForImport(const ModuleSummaryIndex &Index, // FIXME: we may be able to import it by copying it without promotion. return false; + // Don't import functions that are not viable to inline. + if (Summary.isNotViableToInline()) + return false; + // Check references (and potential calls) in the same module. If the current // value references a global that can't be externally referenced it is not // eligible for import. |
