diff options
author | Bjorn Pettersson <bjorn.a.pettersson@ericsson.com> | 2017-01-04 09:41:56 +0000 |
---|---|---|
committer | Bjorn Pettersson <bjorn.a.pettersson@ericsson.com> | 2017-01-04 09:41:56 +0000 |
commit | 3c6ce733f5720b4e13eae85d9aa3ce87b2084f4a (patch) | |
tree | e881e0d35919631cc43aa85f4ad1b7daf2df07b0 /llvm/lib/Target/XCore/XCoreTargetObjectFile.cpp | |
parent | b0bc573ca83728f568c02ab1e9d6d96de4cc8a63 (diff) | |
download | bcm5719-llvm-3c6ce733f5720b4e13eae85d9aa3ce87b2084f4a.tar.gz bcm5719-llvm-3c6ce733f5720b4e13eae85d9aa3ce87b2084f4a.zip |
Fix for InlineSpiller accessing not updated dom tree base information.
Summary:
The InlineSpiller was accessing the DominatorTreeBase directly
through the public data member DT in the MachineDominatorTree.
This is not a good idea as the "cached" information in
SplitCriticalEdges is not applied before the access.
The DominatorTreeBase must be accessed through the member
function getBase() in MachineDominatorTree.
The fault was introduced in r266162.
I think the public data member DT in the MachineDominatorTree
should have been made private in the original code (r215576)
that introduced the concept of lazily updating the
MachineDominatorTree information from
MachineBasicBlock::SplitCriticalEdge().
Patch by Karl-Johan Karlsson <karl-johan.karlsson@ericsson.com>
Reviewers: wmi, qcolombet
Subscribers: llvm-commits, bjope, uabelho
Differential Revision: https://reviews.llvm.org/D27983
llvm-svn: 290950
Diffstat (limited to 'llvm/lib/Target/XCore/XCoreTargetObjectFile.cpp')
0 files changed, 0 insertions, 0 deletions