diff options
| author | Heejin Ahn <aheejin@gmail.com> | 2018-08-22 00:20:02 +0000 |
|---|---|---|
| committer | Heejin Ahn <aheejin@gmail.com> | 2018-08-22 00:20:02 +0000 |
| commit | c4df1d182c13c0665868e39aa7ee1e967368db40 (patch) | |
| tree | 7aa17cf0ddcefa85c2d8ed5da0aaa0b3d027273b /llvm/lib/Target/WebAssembly | |
| parent | 1e8a2c963c804770bb58fbbd0103da2a86217c15 (diff) | |
| download | bcm5719-llvm-c4df1d182c13c0665868e39aa7ee1e967368db40.tar.gz bcm5719-llvm-c4df1d182c13c0665868e39aa7ee1e967368db40.zip | |
[WebAssembly] Change comments on SP writing back (NFC)
Summary: We now write back not to memory but to __stack_pointer global.
Reviewers: dschuff
Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits
Differential Revision: https://reviews.llvm.org/D51074
llvm-svn: 340372
Diffstat (limited to 'llvm/lib/Target/WebAssembly')
| -rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp | 5 | ||||
| -rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.h | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp index 9e33ed75f93..8b156ecc4c6 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp @@ -99,8 +99,9 @@ bool WebAssemblyFrameLowering::needsSP(const MachineFunction &MF, } /// Returns true if the local user-space stack pointer needs to be written back -/// to memory by this function (this is not meaningful if needsSP is false). If -/// false, the stack red zone can be used and only a local SP is needed. +/// to __stack_pointer global by this function (this is not meaningful if +/// needsSP is false). If false, the stack red zone can be used and only a local +/// SP is needed. bool WebAssemblyFrameLowering::needsSPWriteback( const MachineFunction &MF, const MachineFrameInfo &MFI) const { assert(needsSP(MF, MFI)); diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.h b/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.h index e888aaf3aef..5e744ad498b 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.h +++ b/llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.h @@ -24,7 +24,8 @@ class MachineFrameInfo; class WebAssemblyFrameLowering final : public TargetFrameLowering { public: /// Size of the red zone for the user stack (leaf functions can use this much - /// space below the stack pointer without writing it back to memory). + /// space below the stack pointer without writing it back to __stack_pointer + /// global). // TODO: (ABI) Revisit and decide how large it should be. static const size_t RedZoneSize = 128; |

