diff options
author | Heejin Ahn <aheejin@gmail.com> | 2019-02-04 19:13:39 +0000 |
---|---|---|
committer | Heejin Ahn <aheejin@gmail.com> | 2019-02-04 19:13:39 +0000 |
commit | 18c56a07623e496480854f4927bcf1ba5213d177 (patch) | |
tree | cec8a82b24bff109a543144afe8f7b580841d0c2 /llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp | |
parent | 2e862c7555e35e13850f321d754b658d93375b67 (diff) | |
download | bcm5719-llvm-18c56a07623e496480854f4927bcf1ba5213d177.tar.gz bcm5719-llvm-18c56a07623e496480854f4927bcf1ba5213d177.zip |
[WebAssembly] clang-tidy (NFC)
Summary:
This patch fixes clang-tidy warnings on wasm-only files.
The list of checks used is:
`-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming,modernize-*`
(LLVM's default .clang-tidy list is the same except it does not have
`modernize-*`. But I've seen in multiple CLs in LLVM the modernize style
was recommended and code was fixed based on the style, so I added it as
well.)
The common fixes are:
- Variable names start with an uppercase letter
- Function names start with a lowercase letter
- Use `auto` when you use casts so the type is evident
- Use inline initialization for class member variables
- Use `= default` for empty constructors / destructors
- Use `using` in place of `typedef`
Reviewers: sbc100, tlively, aardappel
Subscribers: dschuff, sunfish, jgravelle-google, yurydelendik, kripken, MatzeB, mgorny, rupprecht, llvm-commits
Differential Revision: https://reviews.llvm.org/D57500
llvm-svn: 353075
Diffstat (limited to 'llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp')
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp index f79fe046b19..dc8f3c3efbe 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyPeephole.cpp @@ -57,7 +57,7 @@ FunctionPass *llvm::createWebAssemblyPeephole() { } /// If desirable, rewrite NewReg to a drop register. -static bool MaybeRewriteToDrop(unsigned OldReg, unsigned NewReg, +static bool maybeRewriteToDrop(unsigned OldReg, unsigned NewReg, MachineOperand &MO, WebAssemblyFunctionInfo &MFI, MachineRegisterInfo &MRI) { bool Changed = false; @@ -71,7 +71,7 @@ static bool MaybeRewriteToDrop(unsigned OldReg, unsigned NewReg, return Changed; } -static bool MaybeRewriteToFallthrough(MachineInstr &MI, MachineBasicBlock &MBB, +static bool maybeRewriteToFallthrough(MachineInstr &MI, MachineBasicBlock &MBB, const MachineFunction &MF, WebAssemblyFunctionInfo &MFI, MachineRegisterInfo &MRI, @@ -149,7 +149,7 @@ bool WebAssemblyPeephole::runOnMachineFunction(MachineFunction &MF) { if (MRI.getRegClass(NewReg) != MRI.getRegClass(OldReg)) report_fatal_error("Peephole: call to builtin function with " "wrong signature, from/to mismatch"); - Changed |= MaybeRewriteToDrop(OldReg, NewReg, MO, MFI, MRI); + Changed |= maybeRewriteToDrop(OldReg, NewReg, MO, MFI, MRI); } } } @@ -157,57 +157,57 @@ bool WebAssemblyPeephole::runOnMachineFunction(MachineFunction &MF) { } // Optimize away an explicit void return at the end of the function. case WebAssembly::RETURN_I32: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_I32, WebAssembly::COPY_I32); break; case WebAssembly::RETURN_I64: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_I64, WebAssembly::COPY_I64); break; case WebAssembly::RETURN_F32: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_F32, WebAssembly::COPY_F32); break; case WebAssembly::RETURN_F64: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_F64, WebAssembly::COPY_F64); break; case WebAssembly::RETURN_v16i8: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v16i8, WebAssembly::COPY_V128); break; case WebAssembly::RETURN_v8i16: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v8i16, WebAssembly::COPY_V128); break; case WebAssembly::RETURN_v4i32: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v4i32, WebAssembly::COPY_V128); break; case WebAssembly::RETURN_v2i64: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v2i64, WebAssembly::COPY_V128); break; case WebAssembly::RETURN_v4f32: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v4f32, WebAssembly::COPY_V128); break; case WebAssembly::RETURN_v2f64: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v2f64, WebAssembly::COPY_V128); break; case WebAssembly::RETURN_VOID: - Changed |= MaybeRewriteToFallthrough( + Changed |= maybeRewriteToFallthrough( MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_VOID, WebAssembly::INSTRUCTION_LIST_END); break; |