diff options
author | Heejin Ahn <aheejin@gmail.com> | 2019-02-04 19:13:39 +0000 |
---|---|---|
committer | Heejin Ahn <aheejin@gmail.com> | 2019-02-04 19:13:39 +0000 |
commit | 18c56a07623e496480854f4927bcf1ba5213d177 (patch) | |
tree | cec8a82b24bff109a543144afe8f7b580841d0c2 /llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp | |
parent | 2e862c7555e35e13850f321d754b658d93375b67 (diff) | |
download | bcm5719-llvm-18c56a07623e496480854f4927bcf1ba5213d177.tar.gz bcm5719-llvm-18c56a07623e496480854f4927bcf1ba5213d177.zip |
[WebAssembly] clang-tidy (NFC)
Summary:
This patch fixes clang-tidy warnings on wasm-only files.
The list of checks used is:
`-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming,modernize-*`
(LLVM's default .clang-tidy list is the same except it does not have
`modernize-*`. But I've seen in multiple CLs in LLVM the modernize style
was recommended and code was fixed based on the style, so I added it as
well.)
The common fixes are:
- Variable names start with an uppercase letter
- Function names start with a lowercase letter
- Use `auto` when you use casts so the type is evident
- Use inline initialization for class member variables
- Use `= default` for empty constructors / destructors
- Use `using` in place of `typedef`
Reviewers: sbc100, tlively, aardappel
Subscribers: dschuff, sunfish, jgravelle-google, yurydelendik, kripken, MatzeB, mgorny, rupprecht, llvm-commits
Differential Revision: https://reviews.llvm.org/D57500
llvm-svn: 353075
Diffstat (limited to 'llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp')
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp index f4b74ab1572..b1923dba8d6 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp @@ -18,7 +18,7 @@ #include "llvm/CodeGen/Analysis.h" using namespace llvm; -WebAssemblyFunctionInfo::~WebAssemblyFunctionInfo() {} +WebAssemblyFunctionInfo::~WebAssemblyFunctionInfo() = default; // anchor. void WebAssemblyFunctionInfo::initWARegs() { assert(WARegs.empty()); @@ -26,7 +26,7 @@ void WebAssemblyFunctionInfo::initWARegs() { WARegs.resize(MF.getRegInfo().getNumVirtRegs(), Reg); } -void llvm::ComputeLegalValueVTs(const Function &F, const TargetMachine &TM, +void llvm::computeLegalValueVTs(const Function &F, const TargetMachine &TM, Type *Ty, SmallVectorImpl<MVT> &ValueVTs) { const DataLayout &DL(F.getParent()->getDataLayout()); const WebAssemblyTargetLowering &TLI = @@ -37,16 +37,16 @@ void llvm::ComputeLegalValueVTs(const Function &F, const TargetMachine &TM, for (EVT VT : VTs) { unsigned NumRegs = TLI.getNumRegisters(F.getContext(), VT); MVT RegisterVT = TLI.getRegisterType(F.getContext(), VT); - for (unsigned i = 0; i != NumRegs; ++i) + for (unsigned I = 0; I != NumRegs; ++I) ValueVTs.push_back(RegisterVT); } } -void llvm::ComputeSignatureVTs(const FunctionType *Ty, const Function &F, +void llvm::computeSignatureVTs(const FunctionType *Ty, const Function &F, const TargetMachine &TM, SmallVectorImpl<MVT> &Params, SmallVectorImpl<MVT> &Results) { - ComputeLegalValueVTs(F, TM, Ty->getReturnType(), Results); + computeLegalValueVTs(F, TM, Ty->getReturnType(), Results); MVT PtrVT = MVT::getIntegerVT(TM.createDataLayout().getPointerSizeInBits()); if (Results.size() > 1) { @@ -58,22 +58,22 @@ void llvm::ComputeSignatureVTs(const FunctionType *Ty, const Function &F, } for (auto *Param : Ty->params()) - ComputeLegalValueVTs(F, TM, Param, Params); + computeLegalValueVTs(F, TM, Param, Params); if (Ty->isVarArg()) Params.push_back(PtrVT); } -void llvm::ValTypesFromMVTs(const ArrayRef<MVT> &In, +void llvm::valTypesFromMVTs(const ArrayRef<MVT> &In, SmallVectorImpl<wasm::ValType> &Out) { for (MVT Ty : In) Out.push_back(WebAssembly::toValType(Ty)); } std::unique_ptr<wasm::WasmSignature> -llvm::SignatureFromMVTs(const SmallVectorImpl<MVT> &Results, +llvm::signatureFromMVTs(const SmallVectorImpl<MVT> &Results, const SmallVectorImpl<MVT> &Params) { auto Sig = make_unique<wasm::WasmSignature>(); - ValTypesFromMVTs(Results, Sig->Returns); - ValTypesFromMVTs(Params, Sig->Params); + valTypesFromMVTs(Results, Sig->Returns); + valTypesFromMVTs(Params, Sig->Params); return Sig; } |