diff options
author | Heejin Ahn <aheejin@gmail.com> | 2019-02-04 19:13:39 +0000 |
---|---|---|
committer | Heejin Ahn <aheejin@gmail.com> | 2019-02-04 19:13:39 +0000 |
commit | 18c56a07623e496480854f4927bcf1ba5213d177 (patch) | |
tree | cec8a82b24bff109a543144afe8f7b580841d0c2 /llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp | |
parent | 2e862c7555e35e13850f321d754b658d93375b67 (diff) | |
download | bcm5719-llvm-18c56a07623e496480854f4927bcf1ba5213d177.tar.gz bcm5719-llvm-18c56a07623e496480854f4927bcf1ba5213d177.zip |
[WebAssembly] clang-tidy (NFC)
Summary:
This patch fixes clang-tidy warnings on wasm-only files.
The list of checks used is:
`-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming,modernize-*`
(LLVM's default .clang-tidy list is the same except it does not have
`modernize-*`. But I've seen in multiple CLs in LLVM the modernize style
was recommended and code was fixed based on the style, so I added it as
well.)
The common fixes are:
- Variable names start with an uppercase letter
- Function names start with a lowercase letter
- Use `auto` when you use casts so the type is evident
- Use inline initialization for class member variables
- Use `= default` for empty constructors / destructors
- Use `using` in place of `typedef`
Reviewers: sbc100, tlively, aardappel
Subscribers: dschuff, sunfish, jgravelle-google, yurydelendik, kripken, MatzeB, mgorny, rupprecht, llvm-commits
Differential Revision: https://reviews.llvm.org/D57500
llvm-svn: 353075
Diffstat (limited to 'llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp')
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp index 07c00143024..a67a3af1641 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp @@ -132,7 +132,7 @@ FunctionPass *llvm::createWebAssemblyCFGSort() { return new WebAssemblyCFGSort(); } -static void MaybeUpdateTerminator(MachineBasicBlock *MBB) { +static void maybeUpdateTerminator(MachineBasicBlock *MBB) { #ifndef NDEBUG bool AnyBarrier = false; #endif @@ -227,7 +227,7 @@ struct Entry { /// interrupted by blocks not dominated by their header. /// TODO: There are many opportunities for improving the heuristics here. /// Explore them. -static void SortBlocks(MachineFunction &MF, const MachineLoopInfo &MLI, +static void sortBlocks(MachineFunction &MF, const MachineLoopInfo &MLI, const WebAssemblyExceptionInfo &WEI, const MachineDominatorTree &MDT) { // Prepare for a topological sort: Record the number of predecessors each @@ -319,7 +319,7 @@ static void SortBlocks(MachineFunction &MF, const MachineLoopInfo &MLI, if (!Next) { // If there are no more blocks to process, we're done. if (Ready.empty()) { - MaybeUpdateTerminator(MBB); + maybeUpdateTerminator(MBB); break; } for (;;) { @@ -337,7 +337,7 @@ static void SortBlocks(MachineFunction &MF, const MachineLoopInfo &MLI, } // Move the next block into place and iterate. Next->moveAfter(MBB); - MaybeUpdateTerminator(MBB); + maybeUpdateTerminator(MBB); MBB = Next; } assert(Entries.empty() && "Active sort region list not finished"); @@ -403,7 +403,7 @@ bool WebAssemblyCFGSort::runOnMachineFunction(MachineFunction &MF) { MF.getRegInfo().invalidateLiveness(); // Sort the blocks, with contiguous sort regions. - SortBlocks(MF, MLI, WEI, MDT); + sortBlocks(MF, MLI, WEI, MDT); return true; } |