diff options
author | Eric Christopher <echristo@gmail.com> | 2015-04-28 18:09:05 +0000 |
---|---|---|
committer | Eric Christopher <echristo@gmail.com> | 2015-04-28 18:09:05 +0000 |
commit | 35a8a62125ccfa0ef804584738a295ed5c17750f (patch) | |
tree | 40c0aa1a787865e4c9bb4d3a70c0c1f8b594ec40 /llvm/lib/Target/TargetMachine.cpp | |
parent | 25c94eb1523a56d8bbf26cbc06372927f13ffe07 (diff) | |
download | bcm5719-llvm-35a8a62125ccfa0ef804584738a295ed5c17750f.tar.gz bcm5719-llvm-35a8a62125ccfa0ef804584738a295ed5c17750f.zip |
Add a fixme to resetTargetOptions to explain why it needs to go
away.
llvm-svn: 236009
Diffstat (limited to 'llvm/lib/Target/TargetMachine.cpp')
-rw-r--r-- | llvm/lib/Target/TargetMachine.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/lib/Target/TargetMachine.cpp b/llvm/lib/Target/TargetMachine.cpp index 5807cf7ca32..69900b012c4 100644 --- a/llvm/lib/Target/TargetMachine.cpp +++ b/llvm/lib/Target/TargetMachine.cpp @@ -54,6 +54,11 @@ TargetMachine::~TargetMachine() { } /// \brief Reset the target options based on the function's attributes. +// FIXME: This function needs to go away for a number of reasons: +// a) global state on the TargetMachine is terrible in general, +// b) there's no default state here to keep, +// c) these target options should be passed only on the function +// and not on the TargetMachine (via TargetOptions) at all. void TargetMachine::resetTargetOptions(const Function &F) const { #define RESET_OPTION(X, Y) \ do { \ |