diff options
| author | Dean Michael Berris <dberris@google.com> | 2017-09-08 01:47:56 +0000 |
|---|---|---|
| committer | Dean Michael Berris <dberris@google.com> | 2017-09-08 01:47:56 +0000 |
| commit | 711dec260fc5ad2ec48fe73351bbfb9bd6d843d8 (patch) | |
| tree | be85dfa15db549ba10244cafc5cc222be368a8ee /llvm/lib/Target/PowerPC | |
| parent | 0ff545c018bb2a5e96583e63036bd8464d766918 (diff) | |
| download | bcm5719-llvm-711dec260fc5ad2ec48fe73351bbfb9bd6d843d8.tar.gz bcm5719-llvm-711dec260fc5ad2ec48fe73351bbfb9bd6d843d8.zip | |
[XRay][CodeGen][PowerPC] Fix tail exit codegen for XRay in PPC
Summary:
This fixes code-gen for XRay in PPC. The regression wasn't caught by
codegen tests which we add in this change.
What happened was the following:
- For tail exits, we used to unconditionally prepend the returns/exits
with a pseudo-instruction that gets lowered to the instrumentation
sled (and leave the actual return/exit instruction as-is).
- Changes to the XRay instrumentation pass caused the tail exits to
suddenly also emit the tail exit pseudo-instruction, since the check
for whether a return instruction was also a call instruction meant it
was a tail exit instruction.
- None of the tests caught the regression either due to non-existent
tests, or the tests being disabled/removed for continuous breakage.
This change re-introduces some of the basic tests and verifies that
we're back to a state that allows the back-end to generate appropriate
XRay instrumented binaries for PPC in the presence of tail exits.
Reviewers: echristo, timshen
Subscribers: nemanjai, kbarton, llvm-commits
Differential Revision: https://reviews.llvm.org/D37570
llvm-svn: 312772
Diffstat (limited to 'llvm/lib/Target/PowerPC')
| -rw-r--r-- | llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp b/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp index 841b8c51446..67c849b37bd 100644 --- a/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp +++ b/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp @@ -1131,6 +1131,8 @@ void PPCLinuxAsmPrinter::EmitInstruction(const MachineInstr *MI) { break; } case TargetOpcode::PATCHABLE_TAIL_CALL: + // TODO: Define a trampoline `__xray_FunctionTailExit` and differentiate a + // normal function exit from a tail exit. case TargetOpcode::PATCHABLE_RET: // PPC's tail call instruction, e.g. PPC::TCRETURNdi8, doesn't really // lower to a PPC::B instruction. The PPC::B instruction is generated |

