diff options
| author | Reid Kleckner <rnk@google.com> | 2018-11-01 19:54:45 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2018-11-01 19:54:45 +0000 |
| commit | 4dc0b1ac60f947c23bbb0e20a7efb636c214b0a8 (patch) | |
| tree | be694515ce144c8d6ab1d1031b1f44817faac9ae /llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp | |
| parent | de4f7747837cbd9db9cb393c05283964fbc4a985 (diff) | |
| download | bcm5719-llvm-4dc0b1ac60f947c23bbb0e20a7efb636c214b0a8.tar.gz bcm5719-llvm-4dc0b1ac60f947c23bbb0e20a7efb636c214b0a8.zip | |
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing fall through comments with the LLVM_FALLTHROUGH macro
2. Inserting 'break' before falling through into a case block consisting
of only 'break'.
We were already using this warning with GCC, but its warning behaves
slightly differently. In this patch, the following differences are
relevant:
1. GCC recognizes comments that say "fall through" as annotations, clang
doesn't
2. GCC doesn't warn on "case N: foo(); default: break;", clang does
3. GCC doesn't warn when the case contains a switch, but falls through
the outer case.
I will enable the warning separately in a follow-up patch so that it can
be cleanly reverted if necessary.
Reviewers: alexfh, rsmith, lattner, rtrieu, EricWF, bollu
Differential Revision: https://reviews.llvm.org/D53950
llvm-svn: 345882
Diffstat (limited to 'llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp')
| -rw-r--r-- | llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp b/llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp index 496f2befde5..8890fb8adf4 100644 --- a/llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp +++ b/llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp @@ -357,8 +357,8 @@ BPFAsmParser::parseOperandAsOperator(OperandVector &Operands) { case AsmToken::Plus: { if (getLexer().peekTok().is(AsmToken::Integer)) return MatchOperand_NoMatch; + LLVM_FALLTHROUGH; } - // Fall through. case AsmToken::Equal: case AsmToken::Greater: |
