diff options
author | Mikael Holmen <mikael.holmen@ericsson.com> | 2019-06-12 14:19:22 +0000 |
---|---|---|
committer | Mikael Holmen <mikael.holmen@ericsson.com> | 2019-06-12 14:19:22 +0000 |
commit | 030df51e27e77cd6c216f5299b7d5da6759b1ac4 (patch) | |
tree | 42ff8facc2d33285a62ff185a30c4002b23135ce /llvm/lib/Target/ARM/ARMAsmPrinter.cpp | |
parent | aa6bdf9dcd5f0c82e58e9ba1f25779a5f00ab923 (diff) | |
download | bcm5719-llvm-030df51e27e77cd6c216f5299b7d5da6759b1ac4.tar.gz bcm5719-llvm-030df51e27e77cd6c216f5299b7d5da6759b1ac4.zip |
[ARM] Fix compiler warning
Without this fix clang 3.6 complains with:
../lib/Target/ARM/ARMAsmPrinter.cpp:1473:18: error: variable 'BranchTarget' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
} else if (MI->getOperand(1).isSymbol()) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/Target/ARM/ARMAsmPrinter.cpp:1479:22: note: uninitialized use occurs here
MCInst.addExpr(BranchTarget);
^~~~~~~~~~~~
../lib/Target/ARM/ARMAsmPrinter.cpp:1473:14: note: remove the 'if' if its condition is always true
} else if (MI->getOperand(1).isSymbol()) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/Target/ARM/ARMAsmPrinter.cpp:1465:33: note: initialize the variable 'BranchTarget' to silence this warning
const MCExpr *BranchTarget;
^
= nullptr
1 error generated.
Discussed here:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190610/661417.html
llvm-svn: 363166
Diffstat (limited to 'llvm/lib/Target/ARM/ARMAsmPrinter.cpp')
-rw-r--r-- | llvm/lib/Target/ARM/ARMAsmPrinter.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp index c00ded6e96a..d217cda4adc 100644 --- a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp +++ b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp @@ -1474,7 +1474,8 @@ void ARMAsmPrinter::EmitInstruction(const MachineInstr *MI) { BranchTarget = MCSymbolRefExpr::create( GetExternalSymbolSymbol(MI->getOperand(1).getSymbolName()), OutContext); - } + } else + llvm_unreachable("Unhandled operand kind in Branch Future instruction"); MCInst.addExpr(BranchTarget); } |