summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
diff options
context:
space:
mode:
authorTim Renouf <tpr.llvm@botech.co.uk>2018-02-20 10:03:38 +0000
committerTim Renouf <tpr.llvm@botech.co.uk>2018-02-20 10:03:38 +0000
commit8234b4893ab6ca9e4f0f21d5ec73ae9d8cf5dc3d (patch)
treeb094bf0be5fcb9382a4d407b10305b3e5c53137f /llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
parentb8bf5a6c858b9938865ce668081c559f87bb4051 (diff)
downloadbcm5719-llvm-8234b4893ab6ca9e4f0f21d5ec73ae9d8cf5dc3d.tar.gz
bcm5719-llvm-8234b4893ab6ca9e4f0f21d5ec73ae9d8cf5dc3d.zip
[AMDGPU] stop buffer_store being moved illegally
Summary: The machine instruction scheduler was illegally moving a buffer store past a buffer load with the same descriptor and offset. Fixed by marking buffer ops as mayAlias and isAliased. This may be overly conservative, and we may need to revisit. Subscribers: arsenm, kzhuravl, wdng, nhaehnle, yaxunl, dstuttard, t-tye, llvm-commits Differential Revision: https://reviews.llvm.org/D43332 Change-Id: Iff3173d9e0653e830474546276ab9d30318b8ef7 llvm-svn: 325567
Diffstat (limited to 'llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h')
-rw-r--r--llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h8
1 files changed, 2 insertions, 6 deletions
diff --git a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
index 6eed4fcd8ad..781eea0f94b 100644
--- a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
+++ b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
@@ -70,15 +70,11 @@ public:
}
bool isAliased(const MachineFrameInfo *) const override {
- // FIXME: If we ever change image intrinsics to accept fat pointers, then
- // this could be true for some cases.
- return false;
+ return true;
}
bool mayAlias(const MachineFrameInfo *) const override {
- // FIXME: If we ever change image intrinsics to accept fat pointers, then
- // this could be true for some cases.
- return false;
+ return true;
}
};
OpenPOWER on IntegriCloud