summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
diff options
context:
space:
mode:
authorTim Renouf <tpr.llvm@botech.co.uk>2018-01-12 22:57:24 +0000
committerTim Renouf <tpr.llvm@botech.co.uk>2018-01-12 22:57:24 +0000
commit75ced9d5b8e00b11d568a9d86fb66b67f6dac357 (patch)
tree1dfe4392b28f3e4e4701fe251c68b56d581ab7c4 /llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
parent9f0115fe1cde002412c1721730a1a99a3bdd7257 (diff)
downloadbcm5719-llvm-75ced9d5b8e00b11d568a9d86fb66b67f6dac357.tar.gz
bcm5719-llvm-75ced9d5b8e00b11d568a9d86fb66b67f6dac357.zip
[AMDGPU] stop image_store being moved illegally
Summary: A recent change 321556: AMDGPU: Remove mayLoad/hasSideEffects from MIMG stores can allow the machine instruction scheduler to move an image store past an image load using the same descriptor. V2: Fixed by marking image ops as mayAlias and isAliased. This may be overly conservative, and we may need to revisit. V3: Reverted test change done on 321556. Reviewers: arsenm, nhaehnle, dstuttard Subscribers: llvm-commits, t-tye, yaxunl, wdng, kzhuravl Differential Revision: https://reviews.llvm.org/D41969 llvm-svn: 322419
Diffstat (limited to 'llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h')
-rw-r--r--llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h8
1 files changed, 2 insertions, 6 deletions
diff --git a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
index 02e63f0258e..63875c55df0 100644
--- a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
+++ b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h
@@ -50,15 +50,11 @@ public:
}
bool isAliased(const MachineFrameInfo *) const override {
- // FIXME: If we ever change image intrinsics to accept fat pointers, then
- // this could be true for some cases.
- return false;
+ return true;
}
bool mayAlias(const MachineFrameInfo *) const override {
- // FIXME: If we ever change image intrinsics to accept fat pointers, then
- // this could be true for some cases.
- return false;
+ return true;
}
};
OpenPOWER on IntegriCloud