diff options
| author | Jay Foad <jay.foad@amd.com> | 2019-12-23 13:42:12 +0000 |
|---|---|---|
| committer | Jay Foad <jay.foad@amd.com> | 2019-12-23 15:58:19 +0000 |
| commit | c7c05b0c8a046c9bef46b4e4c7a35c262d1d880a (patch) | |
| tree | 87e091e7b2bb792a4d34c5b8a486728a70ad4241 /llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | |
| parent | 5b1d0dc6bf0618690057bea749830036f70b0491 (diff) | |
| download | bcm5719-llvm-c7c05b0c8a046c9bef46b4e4c7a35c262d1d880a.tar.gz bcm5719-llvm-c7c05b0c8a046c9bef46b4e4c7a35c262d1d880a.zip | |
[AMDGPU] Don't create MachinePointerInfos with an UndefValue pointer
Summary:
The only useful information the UndefValue conveys is the address space,
which MachinePointerInfo can represent directly without referring to an
IR value.
Reviewers: arsenm, rampitec
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71838
Diffstat (limited to 'llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp')
| -rw-r--r-- | llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp index 055bde28cd5..cd2a02376ec 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp @@ -1186,12 +1186,8 @@ Register AMDGPULegalizerInfo::getSegmentAperture( // private_segment_aperture_base_hi. uint32_t StructOffset = (AS == AMDGPUAS::LOCAL_ADDRESS) ? 0x40 : 0x44; - // FIXME: Don't use undef - Value *V = UndefValue::get(PointerType::get( - Type::getInt8Ty(MF.getFunction().getContext()), - AMDGPUAS::CONSTANT_ADDRESS)); - - MachinePointerInfo PtrInfo(V, StructOffset); + // TODO: can we be smarter about machine pointer info? + MachinePointerInfo PtrInfo(AMDGPUAS::CONSTANT_ADDRESS); MachineMemOperand *MMO = MF.getMachineMemOperand( PtrInfo, MachineMemOperand::MOLoad | |
