diff options
| author | Alexander Kornienko <alexfh@google.com> | 2015-01-15 11:41:30 +0000 |
|---|---|---|
| committer | Alexander Kornienko <alexfh@google.com> | 2015-01-15 11:41:30 +0000 |
| commit | 8c0809c7f8a6b8ae8d6b953f9a30a56ec584ff56 (patch) | |
| tree | 98e41eb51466fc2b615e8acf9011cc4076cdd05e /llvm/lib/TableGen | |
| parent | 8ca43224db45c489cf7bf765d057f3d1a92be92b (diff) | |
| download | bcm5719-llvm-8c0809c7f8a6b8ae8d6b953f9a30a56ec584ff56.tar.gz bcm5719-llvm-8c0809c7f8a6b8ae8d6b953f9a30a56ec584ff56.zip | |
Replace size method call of containers to empty method where appropriate
This patch was generated by a clang tidy checker that is being open sourced.
The documentation of that checker is the following:
/// The emptiness of a container should be checked using the empty method
/// instead of the size method. It is not guaranteed that size is a
/// constant-time function, and it is generally more efficient and also shows
/// clearer intent to use empty. Furthermore some containers may implement the
/// empty method but not implement the size method. Using empty whenever
/// possible makes it easier to switch to another container in the future.
Patch by Gábor Horváth!
llvm-svn: 226161
Diffstat (limited to 'llvm/lib/TableGen')
| -rw-r--r-- | llvm/lib/TableGen/Record.cpp | 2 | ||||
| -rw-r--r-- | llvm/lib/TableGen/TGParser.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp index 3a2ae96340c..4ae99037099 100644 --- a/llvm/lib/TableGen/Record.cpp +++ b/llvm/lib/TableGen/Record.cpp @@ -1629,7 +1629,7 @@ std::string DagInit::getAsString() const { std::string Result = "(" + Val->getAsString(); if (!ValName.empty()) Result += ":" + ValName; - if (Args.size()) { + if (!Args.empty()) { Result += " " + Args[0]->getAsString(); if (!ArgNames[0].empty()) Result += ":$" + ArgNames[0]; for (unsigned i = 1, e = Args.size(); i != e; ++i) { diff --git a/llvm/lib/TableGen/TGParser.cpp b/llvm/lib/TableGen/TGParser.cpp index a438cb6fc8f..2445e58e1b9 100644 --- a/llvm/lib/TableGen/TGParser.cpp +++ b/llvm/lib/TableGen/TGParser.cpp @@ -1676,7 +1676,7 @@ std::vector<Init*> TGParser::ParseValueList(Record *CurRec, Record *ArgsRec, unsigned int ArgN = 0; if (ArgsRec && !EltTy) { const std::vector<Init *> &TArgs = ArgsRec->getTemplateArgs(); - if (!TArgs.size()) { + if (TArgs.empty()) { TokError("template argument provided to non-template class"); return std::vector<Init*>(); } |

