diff options
| author | Shafik Yaghmour <syaghmour@apple.com> | 2019-08-02 21:41:50 +0000 |
|---|---|---|
| committer | Shafik Yaghmour <syaghmour@apple.com> | 2019-08-02 21:41:50 +0000 |
| commit | fa5c340ea12e5f5b217246767190d32ccb7df54a (patch) | |
| tree | 9795f3b72e048f8799945a5a911d1316da7ccb80 /llvm/lib/Support | |
| parent | d021617bf7e1a34ac8f8d25146bea1af97580e3b (diff) | |
| download | bcm5719-llvm-fa5c340ea12e5f5b217246767190d32ccb7df54a.tar.gz bcm5719-llvm-fa5c340ea12e5f5b217246767190d32ccb7df54a.zip | |
Fix ClangASTContext::CreateParameterDeclaration to not call addDecl
Summary:
The change https://reviews.llvm.org/D55575 modified ClangASTContext::CreateParameterDeclaration to call decl_ctx->addDecl(decl); this caused a regression since the existing code in DWARFASTParserClang::ParseChildParameters is called with the containing DeclContext. So when end up with cases where we are parsing a parameter for a member function and the parameter is added to the CXXRecordDecl as opposed to the CXXMethodDecl. This example is given in the regression test TestBreakpointInMemberFuncWNonPrimitiveParams.py which without this fix in a modules build leads to assert on setting a breakpoint in a member function with non primitive parameters. This scenario would be common when debugging LLDB or clang.
Differential Revision: https://reviews.llvm.org/D65414
llvm-svn: 367726
Diffstat (limited to 'llvm/lib/Support')
0 files changed, 0 insertions, 0 deletions
