diff options
author | JF Bastien <jfb@google.com> | 2018-05-15 04:06:28 +0000 |
---|---|---|
committer | JF Bastien <jfb@google.com> | 2018-05-15 04:06:28 +0000 |
commit | 93bce5108b92f22644957a54f5994ac029da70e8 (patch) | |
tree | 2181ab8f11046129ce3035a39b30141e08d491d7 /llvm/lib/Support | |
parent | 9d146bbaf7e68be600330e42aac3daa21855d80d (diff) | |
download | bcm5719-llvm-93bce5108b92f22644957a54f5994ac029da70e8.tar.gz bcm5719-llvm-93bce5108b92f22644957a54f5994ac029da70e8.zip |
[NFC] Update comments
Don't prepend function or data name before each comment. Split into its own NFC patch as requested in D46858.
llvm-svn: 332323
Diffstat (limited to 'llvm/lib/Support')
-rw-r--r-- | llvm/lib/Support/Unix/Signals.inc | 39 | ||||
-rw-r--r-- | llvm/lib/Support/Windows/Signals.inc | 22 |
2 files changed, 30 insertions, 31 deletions
diff --git a/llvm/lib/Support/Unix/Signals.inc b/llvm/lib/Support/Unix/Signals.inc index 2c5d3669b7d..33edc2a5d4d 100644 --- a/llvm/lib/Support/Unix/Signals.inc +++ b/llvm/lib/Support/Unix/Signals.inc @@ -62,22 +62,22 @@ static RETSIGTYPE SignalHandler(int Sig); // defined below. static ManagedStatic<sys::SmartMutex<true> > SignalsMutex; -/// InterruptFunction - The function to call if ctrl-c is pressed. +/// The function to call if ctrl-c is pressed. static void (*InterruptFunction)() = nullptr; static ManagedStatic<std::vector<std::string>> FilesToRemove; static StringRef Argv0; -// IntSigs - Signals that represent requested termination. There's no bug -// or failure, or if there is, it's not our direct responsibility. For whatever -// reason, our continued execution is no longer desirable. +// Signals that represent requested termination. There's no bug or failure, or +// if there is, it's not our direct responsibility. For whatever reason, our +// continued execution is no longer desirable. static const int IntSigs[] = { SIGHUP, SIGINT, SIGPIPE, SIGTERM, SIGUSR1, SIGUSR2 }; -// KillSigs - Signals that represent that we have a bug, and our prompt -// termination has been ordered. +// Signals that represent that we have a bug, and our prompt termination has +// been ordered. static const int KillSigs[] = { SIGILL, SIGTRAP, SIGABRT, SIGFPE, SIGBUS, SIGSEGV, SIGQUIT #ifdef SIGSYS @@ -172,10 +172,9 @@ static void UnregisterHandlers() { } -/// RemoveFilesToRemove - Process the FilesToRemove list. This function -/// should be called with the SignalsMutex lock held. -/// NB: This must be an async signal safe function. It cannot allocate or free -/// memory, even in debug builds. +/// Process the FilesToRemove list. This function should be called with the +/// SignalsMutex lock held. NB: This must be an async signal safe function. It +/// cannot allocate or free memory, even in debug builds. static void RemoveFilesToRemove() { // Avoid constructing ManagedStatic in the signal handler. // If FilesToRemove is not constructed, there are no files to remove. @@ -206,7 +205,7 @@ static void RemoveFilesToRemove() { } } -// SignalHandler - The signal handler that runs. +// The signal handler that runs. static RETSIGTYPE SignalHandler(int Sig) { // Restore the signal behavior to default, so that the program actually // crashes when we return and the signal reissues. This also ensures that if @@ -265,7 +264,7 @@ void llvm::sys::SetInterruptFunction(void (*IF)()) { RegisterHandlers(); } -// RemoveFileOnSignal - The public API +// The public API bool llvm::sys::RemoveFileOnSignal(StringRef Filename, std::string* ErrMsg) { { @@ -277,7 +276,7 @@ bool llvm::sys::RemoveFileOnSignal(StringRef Filename, return false; } -// DontRemoveFileOnSignal - The public API +// The public API void llvm::sys::DontRemoveFileOnSignal(StringRef Filename) { sys::SmartScopedLock<true> Guard(*SignalsMutex); std::vector<std::string>::reverse_iterator RI = @@ -287,9 +286,9 @@ void llvm::sys::DontRemoveFileOnSignal(StringRef Filename) { I = FilesToRemove->erase(RI.base()-1); } -/// AddSignalHandler - Add a function to be called when a signal is delivered -/// to the process. The handler can have a cookie passed to it to identify -/// what instance of the handler it is. +/// Add a function to be called when a signal is delivered to the process. The +/// handler can have a cookie passed to it to identify what instance of the +/// handler it is. void llvm::sys::AddSignalHandler(void (*FnPtr)(void *), void *Cookie) { CallBacksToRun->push_back(std::make_pair(FnPtr, Cookie)); RegisterHandlers(); @@ -384,8 +383,8 @@ static int unwindBacktrace(void **StackTrace, int MaxEntries) { } #endif -// PrintStackTrace - In the case of a program crash or fault, print out a stack -// trace so that the user has an indication of why and where we died. +// In the case of a program crash or fault, print out a stack trace so that the +// user has an indication of why and where we died. // // On glibc systems we have the 'backtrace' function, which works nicely, but // doesn't demangle symbols. @@ -464,8 +463,8 @@ static void PrintStackTraceSignalHandler(void *) { void llvm::sys::DisableSystemDialogsOnCrash() {} -/// PrintStackTraceOnErrorSignal - When an error signal (such as SIGABRT or -/// SIGSEGV) is delivered to the process, print a stack trace and then exit. +/// When an error signal (such as SIGABRT or SIGSEGV) is delivered to the +/// process, print a stack trace and then exit. void llvm::sys::PrintStackTraceOnErrorSignal(StringRef Argv0, bool DisableCrashReporting) { ::Argv0 = Argv0; diff --git a/llvm/lib/Support/Windows/Signals.inc b/llvm/lib/Support/Windows/Signals.inc index 8a636d085b0..959376b52f7 100644 --- a/llvm/lib/Support/Windows/Signals.inc +++ b/llvm/lib/Support/Windows/Signals.inc @@ -190,7 +190,7 @@ using namespace llvm; static LONG WINAPI LLVMUnhandledExceptionFilter(LPEXCEPTION_POINTERS ep); static BOOL WINAPI LLVMConsoleCtrlHandler(DWORD dwCtrlType); -// InterruptFunction - The function to call if ctrl-c is pressed. +// The function to call if ctrl-c is pressed. static void (*InterruptFunction)() = 0; static std::vector<std::string> *FilesToRemove = NULL; @@ -387,9 +387,9 @@ namespace llvm { //===----------------------------------------------------------------------===// #ifdef _MSC_VER -/// AvoidMessageBoxHook - Emulates hitting "retry" from an "abort, retry, -/// ignore" CRT debug report dialog. "retry" raises an exception which -/// ultimately triggers our stack dumper. +/// Emulates hitting "retry" from an "abort, retry, ignore" CRT debug report +/// dialog. "retry" raises an exception which ultimately triggers our stack +/// dumper. static LLVM_ATTRIBUTE_UNUSED int AvoidMessageBoxHook(int ReportType, char *Message, int *Return) { // Set *Return to the retry code for the return value of _CrtDbgReport: @@ -447,7 +447,7 @@ static void RegisterHandler() { // else multi-threading problems will ensue. } -// RemoveFileOnSignal - The public API +// The public API bool sys::RemoveFileOnSignal(StringRef Filename, std::string* ErrMsg) { RegisterHandler(); @@ -466,7 +466,7 @@ bool sys::RemoveFileOnSignal(StringRef Filename, std::string* ErrMsg) { return false; } -// DontRemoveFileOnSignal - The public API +// The public API void sys::DontRemoveFileOnSignal(StringRef Filename) { if (FilesToRemove == NULL) return; @@ -500,8 +500,8 @@ void sys::DisableSystemDialogsOnCrash() { _set_error_mode(_OUT_TO_STDERR); } -/// PrintStackTraceOnErrorSignal - When an error signal (such as SIGABRT or -/// SIGSEGV) is delivered to the process, print a stack trace and then exit. +/// When an error signal (such as SIGABRT or SIGSEGV) is delivered to the +/// process, print a stack trace and then exit. void sys::PrintStackTraceOnErrorSignal(StringRef Argv0, bool DisableCrashReporting) { ::Argv0 = Argv0; @@ -557,9 +557,9 @@ void llvm::sys::SetInterruptFunction(void (*IF)()) { } -/// AddSignalHandler - Add a function to be called when a signal is delivered -/// to the process. The handler can have a cookie passed to it to identify -/// what instance of the handler it is. +/// Add a function to be called when a signal is delivered to the process. The +/// handler can have a cookie passed to it to identify what instance of the +/// handler it is. void llvm::sys::AddSignalHandler(void (*FnPtr)(void *), void *Cookie) { CallBacksToRun->push_back(std::make_pair(FnPtr, Cookie)); RegisterHandler(); |