diff options
| author | Cameron Zwarich <zwarich@apple.com> | 2011-02-21 00:22:02 +0000 |
|---|---|---|
| committer | Cameron Zwarich <zwarich@apple.com> | 2011-02-21 00:22:02 +0000 |
| commit | 8731d0cc836cc879f5a7d32248cdd9ccf4e3b69e (patch) | |
| tree | 16ac2df9728120c9958f0a19137f97ec68dd87b8 /llvm/lib/Support | |
| parent | 468b5cbd40259b97807afdcdaf49f59353fb667c (diff) | |
| download | bcm5719-llvm-8731d0cc836cc879f5a7d32248cdd9ccf4e3b69e.tar.gz bcm5719-llvm-8731d0cc836cc879f5a7d32248cdd9ccf4e3b69e.zip | |
The signed version of our "magic number" computation for the integer approximation
of a constant had a minor typo introduced when copying it from the book, which
caused it to favor negative approximations over positive approximations in many
cases. Positive approximations require fewer operations beyond the multiplication.
In the case of division by 3, we still generate code that is a single instruction
larger than GCC's code.
llvm-svn: 126097
Diffstat (limited to 'llvm/lib/Support')
| -rw-r--r-- | llvm/lib/Support/APInt.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Support/APInt.cpp b/llvm/lib/Support/APInt.cpp index 77033428b57..08f36d2af3a 100644 --- a/llvm/lib/Support/APInt.cpp +++ b/llvm/lib/Support/APInt.cpp @@ -1505,7 +1505,7 @@ APInt::ms APInt::magic() const { r2 = r2 - ad; } delta = ad - r2; - } while (q1.ule(delta) || (q1 == delta && r1 == 0)); + } while (q1.ult(delta) || (q1 == delta && r1 == 0)); mag.m = q2 + 1; if (d.isNegative()) mag.m = -mag.m; // resulting magic number |
