summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Support
diff options
context:
space:
mode:
authorReid Kleckner <reid@kleckner.net>2013-12-03 19:13:18 +0000
committerReid Kleckner <reid@kleckner.net>2013-12-03 19:13:18 +0000
commit7c5fdaf1c86741e75a5441a8d24c189acab16693 (patch)
tree59b355f16e6815d6efb1fb8242bac60642b1294a /llvm/lib/Support
parentc8e0f81a376eccd6d4b89eb6c25c54e127af4cde (diff)
downloadbcm5719-llvm-7c5fdaf1c86741e75a5441a8d24c189acab16693.tar.gz
bcm5719-llvm-7c5fdaf1c86741e75a5441a8d24c189acab16693.zip
Return true on success in cl::ExpandResponseFiles
This fixes a logic bug pointed out by Juraj Ivancic. No behavior change because none of the in-tree clients of cl::ExpandResponseFiles check the return value. In this case, the @prefixed arguments are left in the command line. Downstream command line processing has the opportunity to emit errors about it, so this isn't that bad. llvm-svn: 196306
Diffstat (limited to 'llvm/lib/Support')
-rw-r--r--llvm/lib/Support/CommandLine.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp
index 44a88d81e3a..9acaa08bbcc 100644
--- a/llvm/lib/Support/CommandLine.cpp
+++ b/llvm/lib/Support/CommandLine.cpp
@@ -634,7 +634,7 @@ static bool ExpandResponseFile(const char *FName, StringSaver &Saver,
bool cl::ExpandResponseFiles(StringSaver &Saver, TokenizerCallback Tokenizer,
SmallVectorImpl<const char *> &Argv) {
unsigned RspFiles = 0;
- bool AllExpanded = false;
+ bool AllExpanded = true;
// Don't cache Argv.size() because it can change.
for (unsigned I = 0; I != Argv.size(); ) {
OpenPOWER on IntegriCloud