diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-24 18:20:12 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-24 18:20:12 +0000 |
| commit | 90c7f1cc161769853db72e30e76c34b0e4ddf3da (patch) | |
| tree | 3d67820a8a7b4be67a275680897f77df8f188040 /llvm/lib/Support/Windows | |
| parent | 6ccda923e594bff47aade5a2342f01e5d2dbc661 (diff) | |
| download | bcm5719-llvm-90c7f1cc161769853db72e30e76c34b0e4ddf3da.tar.gz bcm5719-llvm-90c7f1cc161769853db72e30e76c34b0e4ddf3da.zip | |
Replace the F_Binary flag with a F_Text one.
After this I will set the default back to F_None. The advantage is that
before this patch forgetting to set F_Binary would corrupt a file on windows.
Forgetting to set F_Text produces one that cannot be read in notepad, which
is a better failure mode :-)
llvm-svn: 202052
Diffstat (limited to 'llvm/lib/Support/Windows')
| -rw-r--r-- | llvm/lib/Support/Windows/Path.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Support/Windows/Path.inc b/llvm/lib/Support/Windows/Path.inc index a72d0bf0b1b..98b2767c011 100644 --- a/llvm/lib/Support/Windows/Path.inc +++ b/llvm/lib/Support/Windows/Path.inc @@ -876,7 +876,7 @@ error_code openFileForWrite(const Twine &Name, int &ResultFD, if (Flags & F_Append) OpenFlags |= _O_APPEND; - if (!(Flags & F_Binary)) + if (Flags & F_Text) OpenFlags |= _O_TEXT; int FD = ::_open_osfhandle(intptr_t(H), OpenFlags); |
