diff options
| author | Pavel Labath <labath@google.com> | 2015-05-21 08:32:18 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2015-05-21 08:32:18 +0000 |
| commit | 39036ac31d1571372a58ceb0044f9867ec3f499e (patch) | |
| tree | 5d8ae94a0ad97e2554870a32871caf87d30d7d0a /llvm/lib/Support/Valgrind.cpp | |
| parent | 7a228ff4397195c5128f08763da36c3939e2cabb (diff) | |
| download | bcm5719-llvm-39036ac31d1571372a58ceb0044f9867ec3f499e.tar.gz bcm5719-llvm-39036ac31d1571372a58ceb0044f9867ec3f499e.zip | |
[NativeProcessLinux] Fix handling of SIGSTOP
Summary:
Previously, NPL tried to reinject SIGSTOP into the inferior in an attempt to get the process to
start in the group-stop state. This was:
a) wrong (reinjection should be controlled by "process handle" lldb setting)
b) racy (it should use Resume for transparent resuming instead of RequestResume)
c) broken (llgs crashed on inferior SIGSTOP)
With this change, SIGSTOP is handled just like any other signal delivered to the inferior: we
stop all threads and report signal reception to lldb. SIGSTOP reinjection does not behave the
same way as it would outside the debugger, but simulating this is a hard problem and is not
normally necessary.
Test Plan: I have added a test which verifies we get SIGSTOP reports and we do not crash.
Reviewers: ovyalov, chaoren
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D9852
llvm-svn: 237880
Diffstat (limited to 'llvm/lib/Support/Valgrind.cpp')
0 files changed, 0 insertions, 0 deletions
