diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-02-19 11:35:39 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-02-19 11:35:39 +0000 |
| commit | f940f0c417d196f037763e0425873ba2e0acf475 (patch) | |
| tree | 852822836b1324a7dd46a3a1e93a21c01f554afe /llvm/lib/Support/Unix | |
| parent | 9f298da9bd4ad5ecaa51fc137fb670fe288950dc (diff) | |
| download | bcm5719-llvm-f940f0c417d196f037763e0425873ba2e0acf475.tar.gz bcm5719-llvm-f940f0c417d196f037763e0425873ba2e0acf475.zip | |
Fix initialization-order bug in llvm::Support::TimeValue. TimeValue::now() is explicitly called during module initialization of lib/Support/Process.cpp. It reads the field of global object PosixZeroTime, which is not guaranteed to be initialized at this point. Found by AddressSanitizer with -fsanitize=init-order option.
llvm-svn: 175509
Diffstat (limited to 'llvm/lib/Support/Unix')
| -rw-r--r-- | llvm/lib/Support/Unix/TimeValue.inc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/lib/Support/Unix/TimeValue.inc b/llvm/lib/Support/Unix/TimeValue.inc index 5cf5a9d44ed..df8558bf8be 100644 --- a/llvm/lib/Support/Unix/TimeValue.inc +++ b/llvm/lib/Support/Unix/TimeValue.inc @@ -48,7 +48,8 @@ TimeValue TimeValue::now() { } return TimeValue( - static_cast<TimeValue::SecondsType>( the_time.tv_sec + PosixZeroTime.seconds_ ), + static_cast<TimeValue::SecondsType>( the_time.tv_sec + + PosixZeroTimeSeconds ), static_cast<TimeValue::NanoSecondsType>( the_time.tv_usec * NANOSECONDS_PER_MICROSECOND ) ); } |
