summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Support/Unix
diff options
context:
space:
mode:
authorPetr Hosek <phosek@chromium.org>2018-05-25 20:39:37 +0000
committerPetr Hosek <phosek@chromium.org>2018-05-25 20:39:37 +0000
commitf92ca01e42b759f6d812d7de0cb6502a6c8477f5 (patch)
tree5129e79fd6748d8b7c92dd45933c46a1ddd78d9c /llvm/lib/Support/Unix
parentf6311c669f92825cb0df3ceac4b447d36035ea64 (diff)
downloadbcm5719-llvm-f92ca01e42b759f6d812d7de0cb6502a6c8477f5.tar.gz
bcm5719-llvm-f92ca01e42b759f6d812d7de0cb6502a6c8477f5.zip
[Support] Avoid normalization in sys::getDefaultTargetTriple
The return value of sys::getDefaultTargetTriple, which is derived from -DLLVM_DEFAULT_TRIPLE, is used to construct tool names, default target, and in the future also to control the search path directly; as such it should be used textually, without interpretation by LLVM. Normalization of this value may lead to unexpected results, for example if we configure LLVM with -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-linux-gnu, normalization will transform that value to x86_64--linux-gnu. Driver will use that value to search for tools prefixed with x86_64--linux-gnu- which may be confusing. This is also inconsistent with the behavior of the --target flag which is taken as-is without any normalization and overrides the value of LLVM_DEFAULT_TARGET_TRIPLE. Users of sys::getDefaultTargetTriple already perform their own normalization as needed, so this change shouldn't impact existing logic. Differential Revision: https://reviews.llvm.org/D47153 llvm-svn: 333307
Diffstat (limited to 'llvm/lib/Support/Unix')
-rw-r--r--llvm/lib/Support/Unix/Host.inc2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Support/Unix/Host.inc b/llvm/lib/Support/Unix/Host.inc
index 5580e63893c..b65f84bf444 100644
--- a/llvm/lib/Support/Unix/Host.inc
+++ b/llvm/lib/Support/Unix/Host.inc
@@ -64,5 +64,5 @@ std::string sys::getDefaultTargetTriple() {
TargetTripleString = EnvTriple;
#endif
- return Triple::normalize(TargetTripleString);
+ return TargetTripleString;
}
OpenPOWER on IntegriCloud