diff options
author | Haojian Wu <hokein@google.com> | 2018-08-20 13:12:54 +0000 |
---|---|---|
committer | Haojian Wu <hokein@google.com> | 2018-08-20 13:12:54 +0000 |
commit | 54829bb3ff750cf8061fcd82db46f3596fa9cbac (patch) | |
tree | 5944f6cdf3edeb19ffb03c05aea502f5f74f3bbf /llvm/lib/Support/StringSaver.cpp | |
parent | 5b78c9d58d9043db6a9c4ca489a40486375776d8 (diff) | |
download | bcm5719-llvm-54829bb3ff750cf8061fcd82db46f3596fa9cbac.tar.gz bcm5719-llvm-54829bb3ff750cf8061fcd82db46f3596fa9cbac.zip |
Fix an undefined behavior when storing an empty StringRef.
Summary: Passing a nullptr to memcpy is UB.
Reviewers: ioeric
Subscribers: llvm-commits, cfe-commits
Differential Revision: https://reviews.llvm.org/D50966
llvm-svn: 340170
Diffstat (limited to 'llvm/lib/Support/StringSaver.cpp')
-rw-r--r-- | llvm/lib/Support/StringSaver.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/lib/Support/StringSaver.cpp b/llvm/lib/Support/StringSaver.cpp index 1ded2bdb09d..bf0ac8de982 100644 --- a/llvm/lib/Support/StringSaver.cpp +++ b/llvm/lib/Support/StringSaver.cpp @@ -13,7 +13,8 @@ using namespace llvm; StringRef StringSaver::save(StringRef S) { char *P = Alloc.Allocate<char>(S.size() + 1); - memcpy(P, S.data(), S.size()); + if (!S.empty()) + memcpy(P, S.data(), S.size()); P[S.size()] = '\0'; return StringRef(P, S.size()); } |