summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Support/ScaledNumber.cpp
diff options
context:
space:
mode:
authorMichael Ilseman <milseman@apple.com>2014-12-12 21:48:03 +0000
committerMichael Ilseman <milseman@apple.com>2014-12-12 21:48:03 +0000
commit5be22a12c2fdb4e13ead4b2e8a8a68f07fb1f270 (patch)
treed32cd1ee5853b7b127f7bc8acbb58e753c5feccd /llvm/lib/Support/ScaledNumber.cpp
parent90482a77b114ba612951233d90f0173d7b7d04a6 (diff)
downloadbcm5719-llvm-5be22a12c2fdb4e13ead4b2e8a8a68f07fb1f270.tar.gz
bcm5719-llvm-5be22a12c2fdb4e13ead4b2e8a8a68f07fb1f270.zip
Clean up static analyzer warnings.
Clang's static analyzer found several potential cases of undefined behavior, use of un-initialized values, and potentially null pointer dereferences in tablegen, Support, MC, and ADT. This cleans them up with specific assertions on the assumptions of the code. llvm-svn: 224154
Diffstat (limited to 'llvm/lib/Support/ScaledNumber.cpp')
-rw-r--r--llvm/lib/Support/ScaledNumber.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/llvm/lib/Support/ScaledNumber.cpp b/llvm/lib/Support/ScaledNumber.cpp
index 725f4649613..3cd75091caf 100644
--- a/llvm/lib/Support/ScaledNumber.cpp
+++ b/llvm/lib/Support/ScaledNumber.cpp
@@ -169,8 +169,7 @@ static std::string toStringAPFloat(uint64_t D, int E, unsigned Precision) {
int Shift = 63 - (NewE - E);
assert(Shift <= LeadingZeros);
assert(Shift == LeadingZeros || NewE == ScaledNumbers::MaxScale);
- assert((Shift & (1u << std::numeric_limits<int>::digits)) == 0 &&
- "undefined behavior");
+ assert(Shift >= 0 && Shift < 64 && "undefined behavior");
D <<= Shift;
E = NewE;
OpenPOWER on IntegriCloud