summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Support/BinaryStreamWriter.cpp
diff options
context:
space:
mode:
authorMichal Gorny <mgorny@gentoo.org>2017-11-27 18:34:52 +0000
committerMichal Gorny <mgorny@gentoo.org>2017-11-27 18:34:52 +0000
commitec6e21427275ce1cdb2580aaa4167b143aab049c (patch)
tree3b2342da37ed92021a3f4d114040e91751e2026e /llvm/lib/Support/BinaryStreamWriter.cpp
parent3decf89ccc783cddcb8a19523cdd8cc82263897d (diff)
downloadbcm5719-llvm-ec6e21427275ce1cdb2580aaa4167b143aab049c.tar.gz
bcm5719-llvm-ec6e21427275ce1cdb2580aaa4167b143aab049c.zip
[cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Prevent unloading shared libraries on Linux when dlclose() is called. This is necessary since command-line option parsing API relies on registering the global option instances in the option parser instance which can be loaded in a different shared library. Given that we can't reliably remove those options when a library is unloaded, the parser ends up containing dangling references. Since glibc has relatively complex library unloading rules, some of the LLVM libraries can be unloaded while others (including the Support library) stay loaded causing quite a mayhem. To reliably prevent that, just forbid unloading all libraries -- it's a very bad idea anyway. While the issue arguably happens only with BUILD_SHARED_LIBS, it may affect any library reusing llvm::cl interface. Based on patch provided Ross Hayward on https://bugs.gentoo.org/617154. Previously hit by Fedora back in Feb 2016: https://lists.freedesktop.org/archives/mesa-dev/2016-February/107242.html Differential Revision: https://reviews.llvm.org/D40459 llvm-svn: 319069
Diffstat (limited to 'llvm/lib/Support/BinaryStreamWriter.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud