diff options
author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2017-02-24 18:31:04 +0000 |
---|---|---|
committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2017-02-24 18:31:04 +0000 |
commit | cdf2bd656a68b614a2224d69072f43690b5141d2 (patch) | |
tree | abbb2a37bd01ef815b2976005c000bb2b4635f76 /llvm/lib/Support/APInt.cpp | |
parent | b078439250daafafa7e0ac01b11beed071566d5b (diff) | |
download | bcm5719-llvm-cdf2bd656a68b614a2224d69072f43690b5141d2.tar.gz bcm5719-llvm-cdf2bd656a68b614a2224d69072f43690b5141d2.zip |
Revert: r296141 [APInt] Add APInt::extractBits() method to extract APInt subrange
The current pattern for extract bits in range is typically:
Mask.lshr(BitOffset).trunc(SubSizeInBits);
Which can be particularly slow for large APInts (MaskSizeInBits > 64) as they require the allocation of memory for the temporary variable.
This is another of the compile time issues identified in PR32037 (see also D30265).
This patch adds the APInt::extractBits() helper method which avoids the temporary memory allocation.
Differential Revision: https://reviews.llvm.org/D30336
llvm-svn: 296147
Diffstat (limited to 'llvm/lib/Support/APInt.cpp')
-rw-r--r-- | llvm/lib/Support/APInt.cpp | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/llvm/lib/Support/APInt.cpp b/llvm/lib/Support/APInt.cpp index f0c8f6be433..8ddbbe3a70d 100644 --- a/llvm/lib/Support/APInt.cpp +++ b/llvm/lib/Support/APInt.cpp @@ -618,38 +618,6 @@ void APInt::flipBit(unsigned bitPosition) { else setBit(bitPosition); } -APInt APInt::extractBits(unsigned numBits, unsigned bitPosition) const { - assert(0 < numBits && "Can't extract zero bits"); - assert(bitPosition < BitWidth && (numBits + bitPosition) <= BitWidth && - "Illegal bit extraction"); - - unsigned loBit = whichBit(bitPosition); - if (isSingleWord()) - return APInt(numBits, VAL >> loBit); - - unsigned loWord = whichWord(bitPosition); - unsigned hiWord = whichWord(bitPosition + numBits - 1); - - // Single word result extracting bits from a single word source. - if (loWord == hiWord) - return APInt(numBits, pVal[loWord] >> loBit); - - // Extracting bits that start on a source word boundary can be done - // as a fast memory copy. - if (loBit == 0) - return APInt(numBits, makeArrayRef(pVal + loWord, 1 + hiWord - loWord)); - - // General case - shift + copy source words into place. - APInt Result(numBits, 0); - uint64_t *pDst = Result.pVal; - for (unsigned word = loWord; word < hiWord; ++word, ++pDst) { - uint64_t w0 = pVal[word + 0]; - uint64_t w1 = pVal[word + 1]; - *pDst = (w0 >> loBit) | (w1 << (APINT_BITS_PER_WORD - loBit)); - } - return Result.clearUnusedBits(); -} - unsigned APInt::getBitsNeeded(StringRef str, uint8_t radix) { assert(!str.empty() && "Invalid string length"); assert((radix == 10 || radix == 8 || radix == 16 || radix == 2 || |