diff options
| author | Zachary Turner <zturner@google.com> | 2017-12-14 22:07:03 +0000 |
|---|---|---|
| committer | Zachary Turner <zturner@google.com> | 2017-12-14 22:07:03 +0000 |
| commit | 260fe3eca6903f23fd017bafb7e555f4be8acf11 (patch) | |
| tree | ef63acf019f5de6c362d767ff1fd8165f083f59d /llvm/lib/ProfileData/SampleProfReader.cpp | |
| parent | 0ab0c1a201ece292fdced1f913fa257bdcb5280f (diff) | |
| download | bcm5719-llvm-260fe3eca6903f23fd017bafb7e555f4be8acf11.tar.gz bcm5719-llvm-260fe3eca6903f23fd017bafb7e555f4be8acf11.zip | |
Fix many -Wsign-compare and -Wtautological-constant-compare warnings.
Most of the -Wsign-compare warnings are due to the fact that
enums are signed by default in the MS ABI, while the
tautological comparison warnings trigger on x86 builds where
sizeof(size_t) is 4 bytes, so N > numeric_limits<unsigned>::max()
is always false.
Differential Revision: https://reviews.llvm.org/D41256
llvm-svn: 320750
Diffstat (limited to 'llvm/lib/ProfileData/SampleProfReader.cpp')
| -rw-r--r-- | llvm/lib/ProfileData/SampleProfReader.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/ProfileData/SampleProfReader.cpp b/llvm/lib/ProfileData/SampleProfReader.cpp index 1028c35e8c2..44547e3dffa 100644 --- a/llvm/lib/ProfileData/SampleProfReader.cpp +++ b/llvm/lib/ProfileData/SampleProfReader.cpp @@ -749,7 +749,7 @@ setupMemoryBuffer(const Twine &Filename) { auto Buffer = std::move(BufferOrErr.get()); // Sanity check the file. - if (Buffer->getBufferSize() > std::numeric_limits<uint32_t>::max()) + if (uint64_t(Buffer->getBufferSize()) > std::numeric_limits<uint32_t>::max()) return sampleprof_error::too_large; return std::move(Buffer); |
