diff options
| author | Xinliang David Li <davidxl@google.com> | 2016-01-18 06:48:01 +0000 |
|---|---|---|
| committer | Xinliang David Li <davidxl@google.com> | 2016-01-18 06:48:01 +0000 |
| commit | 42a13308a17036c61d171f7d03d35e363b0a30bf (patch) | |
| tree | 2b62443111de362786e597e21e6b8970eafb5e54 /llvm/lib/ProfileData/CoverageMappingReader.cpp | |
| parent | 3347e7823ab550917937b20906a0044fdf04fc70 (diff) | |
| download | bcm5719-llvm-42a13308a17036c61d171f7d03d35e363b0a30bf.tar.gz bcm5719-llvm-42a13308a17036c61d171f7d03d35e363b0a30bf.zip | |
[Coverage] move a local var to be BinaryCoverageReader's member
The symtab is logically referenced beyond the call to the create
method. This changes makes sure its lifetime matches that of
the reader.
llvm-svn: 258036
Diffstat (limited to 'llvm/lib/ProfileData/CoverageMappingReader.cpp')
| -rw-r--r-- | llvm/lib/ProfileData/CoverageMappingReader.cpp | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/llvm/lib/ProfileData/CoverageMappingReader.cpp b/llvm/lib/ProfileData/CoverageMappingReader.cpp index d7169bfdcb2..da14ab23294 100644 --- a/llvm/lib/ProfileData/CoverageMappingReader.cpp +++ b/llvm/lib/ProfileData/CoverageMappingReader.cpp @@ -546,33 +546,36 @@ BinaryCoverageReader::create(std::unique_ptr<MemoryBuffer> &ObjectBuffer, StringRef Arch) { std::unique_ptr<BinaryCoverageReader> Reader(new BinaryCoverageReader()); - InstrProfSymtab ProfileNames; StringRef Coverage; uint8_t BytesInAddress; support::endianness Endian; std::error_code EC; if (ObjectBuffer->getBuffer().startswith(TestingFormatMagic)) // This is a special format used for testing. - EC = loadTestingFormat(ObjectBuffer->getBuffer(), ProfileNames, Coverage, - BytesInAddress, Endian); + EC = loadTestingFormat(ObjectBuffer->getBuffer(), Reader->ProfileNames, + Coverage, BytesInAddress, Endian); else - EC = loadBinaryFormat(ObjectBuffer->getMemBufferRef(), ProfileNames, + EC = loadBinaryFormat(ObjectBuffer->getMemBufferRef(), Reader->ProfileNames, Coverage, BytesInAddress, Endian, Arch); if (EC) return EC; if (BytesInAddress == 4 && Endian == support::endianness::little) EC = readCoverageMappingData<uint32_t, support::endianness::little>( - ProfileNames, Coverage, Reader->MappingRecords, Reader->Filenames); + Reader->ProfileNames, Coverage, Reader->MappingRecords, + Reader->Filenames); else if (BytesInAddress == 4 && Endian == support::endianness::big) EC = readCoverageMappingData<uint32_t, support::endianness::big>( - ProfileNames, Coverage, Reader->MappingRecords, Reader->Filenames); + Reader->ProfileNames, Coverage, Reader->MappingRecords, + Reader->Filenames); else if (BytesInAddress == 8 && Endian == support::endianness::little) EC = readCoverageMappingData<uint64_t, support::endianness::little>( - ProfileNames, Coverage, Reader->MappingRecords, Reader->Filenames); + Reader->ProfileNames, Coverage, Reader->MappingRecords, + Reader->Filenames); else if (BytesInAddress == 8 && Endian == support::endianness::big) EC = readCoverageMappingData<uint64_t, support::endianness::big>( - ProfileNames, Coverage, Reader->MappingRecords, Reader->Filenames); + Reader->ProfileNames, Coverage, Reader->MappingRecords, + Reader->Filenames); else return coveragemap_error::malformed; if (EC) |
