diff options
| author | Fangrui Song <maskray@google.com> | 2019-05-02 10:32:03 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2019-05-02 10:32:03 +0000 |
| commit | 8be28cdc5281edbe83886168978303345ca4a78b (patch) | |
| tree | 613ac659e7c0e7384806266757e1fbf34bf418c6 /llvm/lib/Object/ObjectFile.cpp | |
| parent | 71569d0d523465203ba465a89c37d75075a5e2c2 (diff) | |
| download | bcm5719-llvm-8be28cdc5281edbe83886168978303345ca4a78b.tar.gz bcm5719-llvm-8be28cdc5281edbe83886168978303345ca4a78b.zip | |
[Object] Change getSectionName() to return Expected<StringRef>
Summary:
It currently receives an output parameter and returns
std::error_code. Expected<StringRef> fits for this purpose perfectly.
Differential Revision: https://reviews.llvm.org/D61421
llvm-svn: 359774
Diffstat (limited to 'llvm/lib/Object/ObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/ObjectFile.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/llvm/lib/Object/ObjectFile.cpp b/llvm/lib/Object/ObjectFile.cpp index 081e29c21b6..cc0b282665d 100644 --- a/llvm/lib/Object/ObjectFile.cpp +++ b/llvm/lib/Object/ObjectFile.cpp @@ -68,9 +68,8 @@ std::error_code ObjectFile::printSymbolName(raw_ostream &OS, uint32_t ObjectFile::getSymbolAlignment(DataRefImpl DRI) const { return 0; } bool ObjectFile::isSectionBitcode(DataRefImpl Sec) const { - StringRef SectName; - if (!getSectionName(Sec, SectName)) - return SectName == ".llvmbc"; + if (Expected<StringRef> NameOrErr = getSectionName(Sec)) + return *NameOrErr == ".llvmbc"; return false; } |
