diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-04-03 00:19:35 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-04-03 00:19:35 +0000 |
| commit | b4865d698be45ae548284720da4a60fd9f0e3f44 (patch) | |
| tree | b273d6e5939288bd4cf28f7644c3f8dfea6c2f35 /llvm/lib/Object/MachOObjectFile.cpp | |
| parent | 7c6fcd2060ce76d77be683cef491604426c700b4 (diff) | |
| download | bcm5719-llvm-b4865d698be45ae548284720da4a60fd9f0e3f44.tar.gz bcm5719-llvm-b4865d698be45ae548284720da4a60fd9f0e3f44.zip | |
Revert "Fix a nomenclature error in llvm-nm."
This reverts commit r205479.
It turns out that nm does use addresses, it is just that every reasonable
relocatable ELF object has sections with address 0. I have no idea if those
exist in reality, but it at least it shows that llvm-nm should use the name
address.
The added test was includes an unusual .o file with non 0 section addresses. I
created it by hacking ELFObjectWriter.cpp.
Really sorry for the churn.
llvm-svn: 205493
Diffstat (limited to 'llvm/lib/Object/MachOObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/MachOObjectFile.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp index df4e044e714..6955ef090ae 100644 --- a/llvm/lib/Object/MachOObjectFile.cpp +++ b/llvm/lib/Object/MachOObjectFile.cpp @@ -633,8 +633,7 @@ MachOObjectFile::getSymbolSection(DataRefImpl Symb, error_code MachOObjectFile::getSymbolValue(DataRefImpl Symb, uint64_t &Val) const { - // In MachO both relocatable and non-relocatable objects have addresses. - return getSymbolAddress(Symb, Val); + report_fatal_error("getSymbolValue unimplemented in MachOObjectFile"); } void MachOObjectFile::moveSectionNext(DataRefImpl &Sec) const { |
