diff options
author | Pavel Labath <pavel@labath.sk> | 2019-05-16 11:19:02 +0000 |
---|---|---|
committer | Pavel Labath <pavel@labath.sk> | 2019-05-16 11:19:02 +0000 |
commit | 1a8630ac2839d0e73fd3b15dc38501e4c6525a7e (patch) | |
tree | 31954e4bbf4b49b797cd48a7008bf2595a3227fa /llvm/lib/Object/IRObjectFile.cpp | |
parent | eff622b23cc5d64d7b6d07d34a3ad87420a75b05 (diff) | |
download | bcm5719-llvm-1a8630ac2839d0e73fd3b15dc38501e4c6525a7e.tar.gz bcm5719-llvm-1a8630ac2839d0e73fd3b15dc38501e4c6525a7e.zip |
DWARFContext: Return empty data extractors instead of null pointers
Summary:
There are several reasons for doing this:
- generally, there's no reason to differentiate between a section being
absent and it being present, but empty
- it matches more closely what llvm DWARF parser is doing (which also
doesn't differentiate the two cases)
- SymbolFileDWARF also doesn't differentiate the two cases, which makes
porting the rest of sections easier
- it fixes a bug in how the return-null-if-empty logic was implemented
(it returned nullptr only the second time we tried to get the
debug_aranges section), which meant that we hit an assert when trying
to parse an empty-but-present section
Reviewers: JDevlieghere, clayborg, aprantl
Subscribers: zturner, lldb-commits
Differential Revision: https://reviews.llvm.org/D61942
llvm-svn: 360874
Diffstat (limited to 'llvm/lib/Object/IRObjectFile.cpp')
0 files changed, 0 insertions, 0 deletions