diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2019-07-05 11:28:31 +0000 |
|---|---|---|
| committer | Nico Weber <nicolasweber@gmx.de> | 2019-07-05 11:28:31 +0000 |
| commit | fdef18b42d02d69ca3a7be9c8c38a83ace51d9ff (patch) | |
| tree | 2e421dc8b186b490db83f7d2595b0951e0c45e41 /llvm/lib/Object/ELF.cpp | |
| parent | 433edaed127c16fd641d9515d1340a01086058ff (diff) | |
| download | bcm5719-llvm-fdef18b42d02d69ca3a7be9c8c38a83ace51d9ff.tar.gz bcm5719-llvm-fdef18b42d02d69ca3a7be9c8c38a83ace51d9ff.zip | |
lld-link: Make /debugtype: option work better
- The code tried to pass false to split()'s KeepEmpty parameter, but
instead passed it to MaxSplit. As a result, it would never split on
commas. This has been broken since the flag was added in r278056.
- The code used getSpelling() for getting the argument's values, but
getSpelling() always returns the `/debugtype:` prefix without any
values. So if any /debugtype: flag was passed, it always resulted in
an "unknown option:" warning. (The warning code then used the correct
getValue() for printing the invalid option, so the warning looked
kind of like it made sense.) This regressed in r342894.
Slightly improve the test coverage of this feature (but since I don't
know what this flag actually does, there's still no test for the correct
semantics), and add a comment to getSpelling() explaining what it does.
llvm-svn: 365182
Diffstat (limited to 'llvm/lib/Object/ELF.cpp')
0 files changed, 0 insertions, 0 deletions
