diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-07-07 17:12:59 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-07-07 17:12:59 +0000 |
| commit | be8b0ea8542a652207c46fdf9ed412729d248c83 (patch) | |
| tree | a0ec2fa57294540cbe410a6998a6f9e1e6435be2 /llvm/lib/Object/COFFObjectFile.cpp | |
| parent | 76413ecb607d71b800288c8114550d1e90cb0608 (diff) | |
| download | bcm5719-llvm-be8b0ea8542a652207c46fdf9ed412729d248c83.tar.gz bcm5719-llvm-be8b0ea8542a652207c46fdf9ed412729d248c83.zip | |
Delete UnknownAddress. It is a perfectly valid symbol value.
getSymbolValue now returns a value that in convenient for most callers:
* 0 for undefined
* symbol size for common symbols
* offset/address for symbols the rest
Code that needs something more specific can check getSymbolFlags.
llvm-svn: 241605
Diffstat (limited to 'llvm/lib/Object/COFFObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/COFFObjectFile.cpp | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/llvm/lib/Object/COFFObjectFile.cpp b/llvm/lib/Object/COFFObjectFile.cpp index 5f9b4fa6093..bcca9839b47 100644 --- a/llvm/lib/Object/COFFObjectFile.cpp +++ b/llvm/lib/Object/COFFObjectFile.cpp @@ -154,13 +154,8 @@ ErrorOr<StringRef> COFFObjectFile::getSymbolName(DataRefImpl Ref) const { return Result; } -uint64_t COFFObjectFile::getSymbolValue(DataRefImpl Ref) const { - COFFSymbolRef Sym = getCOFFSymbol(Ref); - - if (Sym.isAnyUndefined() || Sym.isCommon()) - return UnknownAddress; - - return Sym.getValue(); +uint64_t COFFObjectFile::getSymbolValueImpl(DataRefImpl Ref) const { + return getCOFFSymbol(Ref).getValue(); } ErrorOr<uint64_t> COFFObjectFile::getSymbolAddress(DataRefImpl Ref) const { |
