summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Object/ArchiveWriter.cpp
diff options
context:
space:
mode:
authorPete Cooper <peter_cooper@apple.com>2015-07-16 00:09:18 +0000
committerPete Cooper <peter_cooper@apple.com>2015-07-16 00:09:18 +0000
commite3c816173635a3604870b25dd80a0451db93799b (patch)
treea272de3abf7598bb90c99cc71a21fae5fb40fe78 /llvm/lib/Object/ArchiveWriter.cpp
parent31d706836c83c690e1803dfb7a1e788e92c46da7 (diff)
downloadbcm5719-llvm-e3c816173635a3604870b25dd80a0451db93799b.tar.gz
bcm5719-llvm-e3c816173635a3604870b25dd80a0451db93799b.zip
Clear kill flags in ARMLoadStoreOptimizer.
The pass here was clearing kill flags on instructions which had their sources killed in the instruction being combined. But given that the new instruction is inserted after the existing ones, any existing instructions with kill flags will lead to the verifier complaining that we are reading an undefined physreg. For example, what we had prior to this optimization is t2STRi12 %R1, %SP, 12 t2STRi12 %R1<kill>, %SP, 16 t2STRi12 %R0<kill>, %SP, 8 and prior to this fix that would generate t2STRi12 %R1<kill>, %SP, 16 t2STRDi8 %R0<kill>, %R1, %SP, 8 This is clearly incorrect as it didn't clear the kill flag on R1 used with offset 16 because there was no kill flag on the instruction with offset 12. After this change we clear the kill flag on the offset 16 instruction because we know it will be used afterwards in the new instruction. I haven't provided a test case. I have a small test, but even it is very sensitive to register allocation order which isn't ideal. llvm-svn: 242359
Diffstat (limited to 'llvm/lib/Object/ArchiveWriter.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud