diff options
author | Oliver Stannard <oliver.stannard@arm.com> | 2017-08-09 09:40:51 +0000 |
---|---|---|
committer | Oliver Stannard <oliver.stannard@arm.com> | 2017-08-09 09:40:51 +0000 |
commit | 7f569a2d549941aa1fe44d97d5c785661e5ee391 (patch) | |
tree | e83678e4f5f139312dfdffd6a0dc272fc12a4a57 /llvm/lib/MC | |
parent | 2cd28b2ba0b4c3d6fb667113e11bc0ff8968ab26 (diff) | |
download | bcm5719-llvm-7f569a2d549941aa1fe44d97d5c785661e5ee391.tar.gz bcm5719-llvm-7f569a2d549941aa1fe44d97d5c785661e5ee391.zip |
[AsmParser] Hash is not a comment on some targets
The '#' token is not a comment for all targets (on ARM and AArch64 it marks an
immediate operand), so we shouldn't treat it as such.
Comments are already converted to AsmToken::EndOfStatement by
AsmLexer::LexLineComment, so this check was unnecessary.
Differential Revision: https://reviews.llvm.org/D36405
llvm-svn: 310457
Diffstat (limited to 'llvm/lib/MC')
-rw-r--r-- | llvm/lib/MC/MCParser/AsmParser.cpp | 10 | ||||
-rw-r--r-- | llvm/lib/MC/MCParser/MCAsmParser.cpp | 8 |
2 files changed, 0 insertions, 18 deletions
diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp index a75476d2298..b0f6a4cd501 100644 --- a/llvm/lib/MC/MCParser/AsmParser.cpp +++ b/llvm/lib/MC/MCParser/AsmParser.cpp @@ -1648,16 +1648,6 @@ bool AsmParser::parseStatement(ParseStatementInfo &Info, Lex(); return false; } - if (Lexer.is(AsmToken::Hash)) { - // Seeing a hash here means that it was an end-of-line comment in - // an asm syntax where hash's are not comment and the previous - // statement parser did not check the end of statement. Relex as - // EndOfStatement. - StringRef CommentStr = parseStringToEndOfStatement(); - Lexer.Lex(); - Lexer.UnLex(AsmToken(AsmToken::EndOfStatement, CommentStr)); - return false; - } // Statements always start with an identifier. AsmToken ID = getTok(); SMLoc IDLoc = ID.getLoc(); diff --git a/llvm/lib/MC/MCParser/MCAsmParser.cpp b/llvm/lib/MC/MCParser/MCAsmParser.cpp index ea36b3b9b3b..6a4c74cd57f 100644 --- a/llvm/lib/MC/MCParser/MCAsmParser.cpp +++ b/llvm/lib/MC/MCParser/MCAsmParser.cpp @@ -40,11 +40,6 @@ bool MCAsmParser::parseTokenLoc(SMLoc &Loc) { } bool MCAsmParser::parseEOL(const Twine &Msg) { - if (getTok().getKind() == AsmToken::Hash) { - StringRef CommentStr = parseStringToEndOfStatement(); - getLexer().Lex(); - getLexer().UnLex(AsmToken(AsmToken::EndOfStatement, CommentStr)); - } if (getTok().getKind() != AsmToken::EndOfStatement) return Error(getTok().getLoc(), Msg); Lex(); @@ -70,9 +65,6 @@ bool MCAsmParser::parseIntToken(int64_t &V, const Twine &Msg) { bool MCAsmParser::parseOptionalToken(AsmToken::TokenKind T) { bool Present = (getTok().getKind() == T); - // if token is EOL and current token is # this is an EOL comment. - if (getTok().getKind() == AsmToken::Hash && T == AsmToken::EndOfStatement) - Present = true; if (Present) parseToken(T); return Present; |