diff options
author | Adrian Prantl <aprantl@apple.com> | 2016-12-16 04:25:54 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2016-12-16 04:25:54 +0000 |
commit | 74a835cda0b0ad6cc58cbecdec1def780b3a4264 (patch) | |
tree | 5cf2e05f96282a25b971308647e6870ccc075aff /llvm/lib/MC | |
parent | cf634b3eb8ab81e8d57fc183465605fef89f1809 (diff) | |
download | bcm5719-llvm-74a835cda0b0ad6cc58cbecdec1def780b3a4264.tar.gz bcm5719-llvm-74a835cda0b0ad6cc58cbecdec1def780b3a4264.zip |
[IR] Remove the DIExpression field from DIGlobalVariable.
This patch implements PR31013 by introducing a
DIGlobalVariableExpression that holds a pair of DIGlobalVariable and
DIExpression.
Currently, DIGlobalVariables holds a DIExpression. This is not the
best way to model this:
(1) The DIGlobalVariable should describe the source level variable,
not how to get to its location.
(2) It makes it unsafe/hard to update the expressions when we call
replaceExpression on the DIGLobalVariable.
(3) It makes it impossible to represent a global variable that is in
more than one location (e.g., a variable with multiple
DW_OP_LLVM_fragment-s). We also moved away from attaching the
DIExpression to DILocalVariable for the same reasons.
This reapplies r289902 with additional testcase upgrades.
<rdar://problem/29250149>
https://llvm.org/bugs/show_bug.cgi?id=31013
Differential Revision: https://reviews.llvm.org/D26769
llvm-svn: 289920
Diffstat (limited to 'llvm/lib/MC')
0 files changed, 0 insertions, 0 deletions