diff options
| author | Adrian McCarthy <amccarth@google.com> | 2018-04-16 17:01:18 +0000 |
|---|---|---|
| committer | Adrian McCarthy <amccarth@google.com> | 2018-04-16 17:01:18 +0000 |
| commit | 978aae4309e29474a25129ba7635ebf3b5fe67d5 (patch) | |
| tree | e9fc975c35202047629716263d952befd2c94f5c /llvm/lib/MC/MachObjectWriter.cpp | |
| parent | 754da0cc7e7913801bbdeb1ff720c16908797d34 (diff) | |
| download | bcm5719-llvm-978aae4309e29474a25129ba7635ebf3b5fe67d5.tar.gz bcm5719-llvm-978aae4309e29474a25129ba7635ebf3b5fe67d5.zip | |
Remove faulty assertion in llvm-pdbutil
If a class's first data member is an instance of an empty class, then an
assertion in the PrettyClassLayoutGraphicalDumper would fail. The
storage is reserved, but it's not marked as in use.
As far as I understand, it's the assertion that's faulty, so I removed it
and updated the nearby comment.
Found by running llvm-pdbutil against its own PDB, and this assertion would
fail on HashAdjusters, which is a HashTable whose first data member is a
TraitsT, which is a PdbHashTraits<T>, which is an empty struct. (The struct
has a specialization for uint32_t, but that specialization doesn't apply
here because the T is actually ulittle32_t.)
Differential Revision: https://reviews.llvm.org/D45645
llvm-svn: 330135
Diffstat (limited to 'llvm/lib/MC/MachObjectWriter.cpp')
0 files changed, 0 insertions, 0 deletions
