diff options
author | Nathan Jeffords <blunted2night@gmail.com> | 2010-05-12 07:36:03 +0000 |
---|---|---|
committer | Nathan Jeffords <blunted2night@gmail.com> | 2010-05-12 07:36:03 +0000 |
commit | d2de49dddaec5bd4e6f6d2ac8997841cd18e6644 (patch) | |
tree | af19a93ee133eb1600f7a2e60c5a4a3edb11f434 /llvm/lib/MC/MCSectionCOFF.cpp | |
parent | c316e4ef508f315bf4f3c80bd3bb2b5c85bb3606 (diff) | |
download | bcm5719-llvm-d2de49dddaec5bd4e6f6d2ac8997841cd18e6644.tar.gz bcm5719-llvm-d2de49dddaec5bd4e6f6d2ac8997841cd18e6644.zip |
stylistic change to MCSectionCOFF::PrintSwitchToSection COMDAT handling
Made a stylistic changed to the code/comments related to the unsupported COMDAT selection type IMAGE_COMDAT_SELECT_LARGEST based on from Anton Korobeynikov.
llvm-svn: 103590
Diffstat (limited to 'llvm/lib/MC/MCSectionCOFF.cpp')
-rw-r--r-- | llvm/lib/MC/MCSectionCOFF.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/llvm/lib/MC/MCSectionCOFF.cpp b/llvm/lib/MC/MCSectionCOFF.cpp index 786bc7bc035..d57bb0cd52b 100644 --- a/llvm/lib/MC/MCSectionCOFF.cpp +++ b/llvm/lib/MC/MCSectionCOFF.cpp @@ -50,9 +50,6 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, if (getCharacteristics() & MCSectionCOFF::IMAGE_SCN_LNK_COMDAT) { switch (Selection) { - default: - assert (0 && "unsupported COFF selection type"); - break; case IMAGE_COMDAT_SELECT_NODUPLICATES: OS << "\t.linkonce one_only\n"; break; @@ -65,12 +62,15 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, case IMAGE_COMDAT_SELECT_EXACT_MATCH: OS << "\t.linkonce same_contents\n"; break; - // ".linkonce largest" is not documented as being an option. - // It seems odd that a link attribute designed essentially for PE/COFF - // wouldn't support all the options (at least as of binutils 2.20) - //case IMAGE_COMDAT_SELECT_LARGEST: + //NOTE: as of binutils 2.20, there is no way to specifiy select largest + // with the .linkonce directive. For now, we treat it as an invalid + // comdat selection value. + case IMAGE_COMDAT_SELECT_LARGEST: // OS << "\t.linkonce largest\n"; // break; + default: + assert (0 && "unsupported COFF selection type"); + break; } } } |