diff options
| author | Alexander Kornienko <alexfh@google.com> | 2015-01-15 11:41:30 +0000 |
|---|---|---|
| committer | Alexander Kornienko <alexfh@google.com> | 2015-01-15 11:41:30 +0000 |
| commit | 8c0809c7f8a6b8ae8d6b953f9a30a56ec584ff56 (patch) | |
| tree | 98e41eb51466fc2b615e8acf9011cc4076cdd05e /llvm/lib/MC/MCParser | |
| parent | 8ca43224db45c489cf7bf765d057f3d1a92be92b (diff) | |
| download | bcm5719-llvm-8c0809c7f8a6b8ae8d6b953f9a30a56ec584ff56.tar.gz bcm5719-llvm-8c0809c7f8a6b8ae8d6b953f9a30a56ec584ff56.zip | |
Replace size method call of containers to empty method where appropriate
This patch was generated by a clang tidy checker that is being open sourced.
The documentation of that checker is the following:
/// The emptiness of a container should be checked using the empty method
/// instead of the size method. It is not guaranteed that size is a
/// constant-time function, and it is generally more efficient and also shows
/// clearer intent to use empty. Furthermore some containers may implement the
/// empty method but not implement the size method. Using empty whenever
/// possible makes it easier to switch to another container in the future.
Patch by Gábor Horváth!
llvm-svn: 226161
Diffstat (limited to 'llvm/lib/MC/MCParser')
| -rw-r--r-- | llvm/lib/MC/MCParser/AsmParser.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp index 8eff90a9ef7..70877c5914e 100644 --- a/llvm/lib/MC/MCParser/AsmParser.cpp +++ b/llvm/lib/MC/MCParser/AsmParser.cpp @@ -3275,7 +3275,7 @@ bool AsmParser::parseDirectiveMacro(SMLoc DirectiveLoc) { MCAsmMacroParameters Parameters; while (getLexer().isNot(AsmToken::EndOfStatement)) { - if (Parameters.size() && Parameters.back().Vararg) + if (!Parameters.empty() && Parameters.back().Vararg) return Error(Lexer.getLoc(), "Vararg parameter '" + Parameters.back().Name + "' should be last one in the list of parameters."); |

