diff options
author | Kevin Enderby <enderby@apple.com> | 2010-10-04 20:17:24 +0000 |
---|---|---|
committer | Kevin Enderby <enderby@apple.com> | 2010-10-04 20:17:24 +0000 |
commit | a68d004d88f71b2d4762c53258ec2826f6c5ef52 (patch) | |
tree | a80f0ad7452ca49715d67dea1a585bdcfa270b5a /llvm/lib/MC/MCParser/AsmParser.cpp | |
parent | f70898affae4856ab7c5da4a55519d3a4c9b5fb7 (diff) | |
download | bcm5719-llvm-a68d004d88f71b2d4762c53258ec2826f6c5ef52.tar.gz bcm5719-llvm-a68d004d88f71b2d4762c53258ec2826f6c5ef52.zip |
Incorporate suggestions by Daniel Dunbar after his review. Thanks Daniel!
1) Changed ValidateDwarfFileNumber() to isValidDwarfFileNumber() to be better
named. Since it is just a predicate and isn't actually changing any state.
2) Added a missing return in the comments for setCurrentDwarfLoc() in
include/llvm/MC/MCContext.h for fix formatting.
3) Changed clearDwarfLocSeen() to ClearDwarfLocSeen() since it does change
state.
4) Simplified the last test in isValidDwarfFileNumber() to just a one line
boolean test of MCDwarfFiles[FileNumber] != 0 for the final return statement.
llvm-svn: 115551
Diffstat (limited to 'llvm/lib/MC/MCParser/AsmParser.cpp')
-rw-r--r-- | llvm/lib/MC/MCParser/AsmParser.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp index 688827d2c76..974e4ab0a64 100644 --- a/llvm/lib/MC/MCParser/AsmParser.cpp +++ b/llvm/lib/MC/MCParser/AsmParser.cpp @@ -2031,7 +2031,7 @@ bool GenericAsmParser::ParseDirectiveLoc(StringRef, SMLoc DirectiveLoc) { int64_t FileNumber = getTok().getIntVal(); if (FileNumber < 1) return TokError("file number less than one in '.loc' directive"); - if (!getContext().ValidateDwarfFileNumber(FileNumber)) + if (!getContext().isValidDwarfFileNumber(FileNumber)) return TokError("unassigned file number in '.loc' directive"); Lex(); |