diff options
author | Martin Storsjo <martin@martin.st> | 2018-07-25 18:35:42 +0000 |
---|---|---|
committer | Martin Storsjo <martin@martin.st> | 2018-07-25 18:35:42 +0000 |
commit | ff33a95ed44b9c146d3b58517717a4163b479b02 (patch) | |
tree | 1a5ce9e0ec6d53b7fcd6bd3739919d19d432c4a5 /llvm/lib/MC/MCAsmInfoCOFF.cpp | |
parent | d2662c32fbb8ded38cd48fea954aea66864eb37d (diff) | |
download | bcm5719-llvm-ff33a95ed44b9c146d3b58517717a4163b479b02.tar.gz bcm5719-llvm-ff33a95ed44b9c146d3b58517717a4163b479b02.zip |
[COFF] Use comdat shared constants for MinGW as well
GNU binutils tools have no problems with this kind of shared constants,
provided that we actually hook it up completely in AsmPrinter and
produce a global symbol.
This effectively reverts SVN r335918 by hooking the rest of it up
properly.
This feature was implemented originally in SVN r213006, with no reason
for why it can't be used for MinGW other than the fact that GCC doesn't
do it while MSVC does.
Differential Revision: https://reviews.llvm.org/D49646
llvm-svn: 337951
Diffstat (limited to 'llvm/lib/MC/MCAsmInfoCOFF.cpp')
-rw-r--r-- | llvm/lib/MC/MCAsmInfoCOFF.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/llvm/lib/MC/MCAsmInfoCOFF.cpp b/llvm/lib/MC/MCAsmInfoCOFF.cpp index d8fb875b67c..8bb02c3f649 100644 --- a/llvm/lib/MC/MCAsmInfoCOFF.cpp +++ b/llvm/lib/MC/MCAsmInfoCOFF.cpp @@ -45,11 +45,6 @@ MCAsmInfoCOFF::MCAsmInfoCOFF() { // If this is a COFF target, assume that it supports associative comdats. It's // part of the spec. HasCOFFAssociativeComdats = true; - - // We can generate constants in comdat sections that can be shared, - // but in order not to create null typed symbols, we actually need to - // make them global symbols as well. - HasCOFFComdatConstants = true; } void MCAsmInfoMicrosoft::anchor() {} @@ -63,7 +58,4 @@ MCAsmInfoGNUCOFF::MCAsmInfoGNUCOFF() { // comdats for jump tables, unwind information, and other data associated with // a function. HasCOFFAssociativeComdats = false; - - // We don't create constants in comdat sections for MinGW. - HasCOFFComdatConstants = false; } |