diff options
| author | Jason Liu <jasonliu.development@gmail.com> | 2019-11-08 09:26:28 -0500 |
|---|---|---|
| committer | David Tenty <daltenty@ibm.com> | 2019-11-08 09:30:10 -0500 |
| commit | 0dc0572b48ed889e6f750fd65b876a0420805377 (patch) | |
| tree | 266c8f476b8d4b96db8ef9cea064169462ed9edd /llvm/lib/MC/MCAsmInfo.cpp | |
| parent | e25bc5e0247141cb31093a370e22fe3249bdbb05 (diff) | |
| download | bcm5719-llvm-0dc0572b48ed889e6f750fd65b876a0420805377.tar.gz bcm5719-llvm-0dc0572b48ed889e6f750fd65b876a0420805377.zip | |
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
Diffstat (limited to 'llvm/lib/MC/MCAsmInfo.cpp')
| -rw-r--r-- | llvm/lib/MC/MCAsmInfo.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/MC/MCAsmInfo.cpp b/llvm/lib/MC/MCAsmInfo.cpp index 71e51e320f8..420dbaa80ae 100644 --- a/llvm/lib/MC/MCAsmInfo.cpp +++ b/llvm/lib/MC/MCAsmInfo.cpp @@ -100,7 +100,7 @@ MCAsmInfo::getExprForFDESymbol(const MCSymbol *Sym, return MCBinaryExpr::createSub(Res, PC, Context); } -static bool isAcceptableChar(char C) { +bool MCAsmInfo::isAcceptableChar(char C) const { return (C >= 'a' && C <= 'z') || (C >= 'A' && C <= 'Z') || (C >= '0' && C <= '9') || C == '_' || C == '$' || C == '.' || C == '@'; } |

