diff options
author | Benjamin Kramer <benny.kra@googlemail.com> | 2010-08-16 23:00:12 +0000 |
---|---|---|
committer | Benjamin Kramer <benny.kra@googlemail.com> | 2010-08-16 23:00:12 +0000 |
commit | be6cca2b7db45f9ae5db2272a41987d2155f5cab (patch) | |
tree | 3fc051f49508b98b653cd535abf6d04c4c486e42 /llvm/lib/MC/ELFObjectWriter.cpp | |
parent | 6304db3896612476b9a47f2eb3254587af4aa8ed (diff) | |
download | bcm5719-llvm-be6cca2b7db45f9ae5db2272a41987d2155f5cab.tar.gz bcm5719-llvm-be6cca2b7db45f9ae5db2272a41987d2155f5cab.zip |
Silence warnings and simplify code. Eliminate a 32/64 bit portability issue.
llvm-svn: 111201
Diffstat (limited to 'llvm/lib/MC/ELFObjectWriter.cpp')
-rw-r--r-- | llvm/lib/MC/ELFObjectWriter.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp index 5f7ef1217d7..4d0b374196c 100644 --- a/llvm/lib/MC/ELFObjectWriter.cpp +++ b/llvm/lib/MC/ELFObjectWriter.cpp @@ -545,14 +545,13 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, if (IsPCRel) { Type = ELF::R_X86_64_PC32; } else { - switch (Fixup.getKind()) { + switch ((unsigned)Fixup.getKind()) { + default: llvm_unreachable("invalid fixup kind!"); case FK_Data_8: Type = ELF::R_X86_64_64; break; case X86::reloc_pcrel_4byte: case FK_Data_4: - long Offset; - Offset = Target.getConstant(); // check that the offset fits within a signed long - if (!(((long) -1 << 31) & Offset) || (((long) -1 << 31) & Offset) == ((long) -1 << 31)) + if (isInt<32>(Target.getConstant())) Type = ELF::R_X86_64_32S; else Type = ELF::R_X86_64_32; |