diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2013-08-25 10:46:39 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2013-08-25 10:46:39 +0000 |
| commit | ba689b33152d195202e58471d16a49930c8435b3 (patch) | |
| tree | 9a2dea6f47675a97299afbc6de1afac1bcaf4f1f /llvm/lib/IR | |
| parent | b78df507c838e9c23afb9f8aa1bbbad85c1ef56a (diff) | |
| download | bcm5719-llvm-ba689b33152d195202e58471d16a49930c8435b3.tar.gz bcm5719-llvm-ba689b33152d195202e58471d16a49930c8435b3.zip | |
Fix a bug where we would corrupt the offset when evaluating
a non-constant GEP.
I don't have any test case that demonstrates this, Nadav (indirectly)
pointed this out in code review. I'm not sure how possible it is to
contrive a test case for the current users of this code that triggers
the bad issue sadly.
llvm-svn: 189188
Diffstat (limited to 'llvm/lib/IR')
| -rw-r--r-- | llvm/lib/IR/Value.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/IR/Value.cpp b/llvm/lib/IR/Value.cpp index afa9291c9ef..6698f832b25 100644 --- a/llvm/lib/IR/Value.cpp +++ b/llvm/lib/IR/Value.cpp @@ -411,8 +411,10 @@ Value *Value::stripAndAccumulateInBoundsConstantOffsets(const DataLayout &DL, if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { if (!GEP->isInBounds()) return V; - if (!GEP->accumulateConstantOffset(DL, Offset)) + APInt GEPOffset(Offset); + if (!GEP->accumulateConstantOffset(DL, GEPOffset)) return V; + Offset = GEPOffset; V = GEP->getPointerOperand(); } else if (Operator::getOpcode(V) == Instruction::BitCast) { V = cast<Operator>(V)->getOperand(0); |
