diff options
| author | Mehdi Amini <mehdi.amini@apple.com> | 2016-10-05 01:04:02 +0000 |
|---|---|---|
| committer | Mehdi Amini <mehdi.amini@apple.com> | 2016-10-05 01:04:02 +0000 |
| commit | 2bcac0fac4925e76fa9133e20d7422821e74534e (patch) | |
| tree | f26adaf18ef94a13b649896590016a317af74845 /llvm/lib/IR | |
| parent | a28bb09f281b6a9685944f45f496c6892b1aea22 (diff) | |
| download | bcm5719-llvm-2bcac0fac4925e76fa9133e20d7422821e74534e.tar.gz bcm5719-llvm-2bcac0fac4925e76fa9133e20d7422821e74534e.zip | |
Revert "Re-commit "Use StringRef in Support/Darf APIs (NFC)""
One test seems randomly broken: DebugInfo/X86/gnu-public-names.ll
llvm-svn: 283285
Diffstat (limited to 'llvm/lib/IR')
| -rw-r--r-- | llvm/lib/IR/AsmWriter.cpp | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/llvm/lib/IR/AsmWriter.cpp b/llvm/lib/IR/AsmWriter.cpp index ac7c915e839..fa67425bc6c 100644 --- a/llvm/lib/IR/AsmWriter.cpp +++ b/llvm/lib/IR/AsmWriter.cpp @@ -1418,8 +1418,7 @@ struct MDFieldPrinter { void MDFieldPrinter::printTag(const DINode *N) { Out << FS << "tag: "; - auto Tag = dwarf::TagString(N->getTag()); - if (!Tag.empty()) + if (const char *Tag = dwarf::TagString(N->getTag())) Out << Tag; else Out << N->getTag(); @@ -1427,8 +1426,7 @@ void MDFieldPrinter::printTag(const DINode *N) { void MDFieldPrinter::printMacinfoType(const DIMacroNode *N) { Out << FS << "type: "; - auto Type = dwarf::MacinfoString(N->getMacinfoType()); - if (!Type.empty()) + if (const char *Type = dwarf::MacinfoString(N->getMacinfoType())) Out << Type; else Out << N->getMacinfoType(); @@ -1511,8 +1509,7 @@ void MDFieldPrinter::printDwarfEnum(StringRef Name, IntTy Value, return; Out << FS << Name << ": "; - auto S = toString(Value); - if (!S.empty()) + if (const char *S = toString(Value)) Out << S; else Out << Value; @@ -1846,8 +1843,8 @@ static void writeDIExpression(raw_ostream &Out, const DIExpression *N, FieldSeparator FS; if (N->isValid()) { for (auto I = N->expr_op_begin(), E = N->expr_op_end(); I != E; ++I) { - auto OpStr = dwarf::OperationEncodingString(I->getOp()); - assert(!OpStr.empty() && "Expected valid opcode"); + const char *OpStr = dwarf::OperationEncodingString(I->getOp()); + assert(OpStr && "Expected valid opcode"); Out << FS << OpStr; for (unsigned A = 0, AE = I->getNumArgs(); A != AE; ++A) |
