diff options
| author | David Tweed <david.tweed@arm.com> | 2013-03-19 10:16:40 +0000 |
|---|---|---|
| committer | David Tweed <david.tweed@arm.com> | 2013-03-19 10:16:40 +0000 |
| commit | 298e4192ea6ac2dc56a3fbbb881124bec2da47e0 (patch) | |
| tree | 1f7f9d0d5286bb5b0d9031bc981c8bfca83f8aa7 /llvm/lib/IR | |
| parent | ffb4ca8bb4e8a1f1880d7ed59aacb92e03881abc (diff) | |
| download | bcm5719-llvm-298e4192ea6ac2dc56a3fbbb881124bec2da47e0.tar.gz bcm5719-llvm-298e4192ea6ac2dc56a3fbbb881124bec2da47e0.zip | |
The testing to ensure a vector of zeros of type floating point isn't misclassified as negative zero can be simplified, as pointed out by Duncan Sands.
llvm-svn: 177386
Diffstat (limited to 'llvm/lib/IR')
| -rw-r--r-- | llvm/lib/IR/Constants.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/llvm/lib/IR/Constants.cpp b/llvm/lib/IR/Constants.cpp index 70f7e0176e8..1abb6564355 100644 --- a/llvm/lib/IR/Constants.cpp +++ b/llvm/lib/IR/Constants.cpp @@ -53,12 +53,9 @@ bool Constant::isNegativeZeroValue() const { if (SplatCFP && SplatCFP->isZero() && SplatCFP->isNegative()) return true; - // However, vectors of zeroes which are floating point represent +0.0's. - if (const ConstantAggregateZero *CAZ = dyn_cast<ConstantAggregateZero>(this)) - if (const VectorType *VT = dyn_cast<VectorType>(CAZ->getType())) - if (VT->getElementType()->isFloatingPointTy()) - // As it's a CAZ, we know it's the zero bit-pattern (ie, +0.0) in each element. - return false; + // We've already handled true FP case; any other FP vectors can't represent -0.0. + if (getType()->isFPOrFPVectorTy()) + return false; // Otherwise, just use +0.0. return isNullValue(); |
