diff options
| author | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2015-03-28 01:22:37 +0000 |
|---|---|---|
| committer | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2015-03-28 01:22:37 +0000 |
| commit | a0f35592bea616b7d5aace41b64e52b2639db2e5 (patch) | |
| tree | 70fd837a1181e68d76c18d32fbb35a24dd8b3b9b /llvm/lib/IR/Verifier.cpp | |
| parent | 4ba377561f23c8754ab22ba153ac6843b55194f8 (diff) | |
| download | bcm5719-llvm-a0f35592bea616b7d5aace41b64e52b2639db2e5.tar.gz bcm5719-llvm-a0f35592bea616b7d5aace41b64e52b2639db2e5.zip | |
[CodeGen] "PromoteInteger" f32 to f64 doesn't make sense.
The original f32->f64 promotion logic was refactored into roughly the
currently shape in r37781. However, starting with r132263, the
legalizer has been split into different kinds, and the previous
"Promote" (which did the right thing) was search-and-replace'd into
"PromoteInteger". The divide gradually deepened, with type legalization
("PromoteInteger") being separated from ops legalization
("Promote", which still works for floating point ops).
Fast-forward to today: there's no in-tree target with legal f64 but
illegal f32 (rather: no tests were harmed in the making of this patch).
With such a target, i.e., if you trick the legalizer into going through
the PromoteInteger path for FP, you get the expected brokenness.
For instance, there's no PromoteIntRes_FADD (the name itself sounds
wrong), so we'll just hit some assert in the PromoteInteger path.
Don't pretend we can promote f32 to f64. Instead, always soften.
llvm-svn: 233464
Diffstat (limited to 'llvm/lib/IR/Verifier.cpp')
0 files changed, 0 insertions, 0 deletions
