summaryrefslogtreecommitdiffstats
path: root/llvm/lib/IR/Verifier.cpp
diff options
context:
space:
mode:
authorPhilip Reames <listmail@philipreames.com>2014-12-01 21:18:12 +0000
committerPhilip Reames <listmail@philipreames.com>2014-12-01 21:18:12 +0000
commit337c4bd4abac1198312d5d009cf6185063c97812 (patch)
tree00827474d1dfde3fc19d86ff341617a7d9069ed3 /llvm/lib/IR/Verifier.cpp
parent5b62eb9b4845c3e88c5a2f467084c323106df7b6 (diff)
downloadbcm5719-llvm-337c4bd4abac1198312d5d009cf6185063c97812.tar.gz
bcm5719-llvm-337c4bd4abac1198312d5d009cf6185063c97812.zip
[Statepoints 1/4] Statepoint infrastructure for garbage collection: IR Intrinsics
The statepoint intrinsics are intended to enable precise root tracking through the compiler as to support garbage collectors of all types. The addition of the statepoint intrinsics to LLVM should have no impact on the compilation of any program which does not contain them. There are no side tables created, no extra metadata, and no inhibited optimizations. A statepoint works by transforming a call site (or safepoint poll site) into an explicit relocation operation. It is the frontend's responsibility (or eventually the safepoint insertion pass we've developed, but that's not part of this patch series) to ensure that any live pointer to a GC object is correctly added to the statepoint and explicitly relocated. The relocated value is just a normal SSA value (as seen by the optimizer), so merges of relocated and unrelocated values are just normal phis. The explicit relocation operation, the fact the statepoint is assumed to clobber all memory, and the optimizers standard semantics ensure that the relocations flow through IR optimizations correctly. This is the first patch in a small series. This patch contains only the IR parts; the documentation and backend support will be following separately. The entire series can be seen as one combined whole in http://reviews.llvm.org/D5683. Reviewed by: atrick, ributzka llvm-svn: 223078
Diffstat (limited to 'llvm/lib/IR/Verifier.cpp')
-rw-r--r--llvm/lib/IR/Verifier.cpp81
1 files changed, 81 insertions, 0 deletions
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 9698dbd77fd..887631b0171 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -2559,7 +2559,88 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) {
Assert1(isa<ConstantInt>(CI.getArgOperand(1)),
"llvm.invariant.end parameter #2 must be a constant integer", &CI);
break;
+
+ case Intrinsic::experimental_gc_statepoint: {
+ // target, # call args = 0, # deopt args = 0, #gc args = 0 -> 4 args
+ assert(CI.getNumArgOperands() >= 4 &&
+ "not enough arguments to statepoint");
+ for (User* U : CI.users()) {
+ const CallInst* GCRelocCall = cast<const CallInst>(U);
+ const Function *GCRelocFn = GCRelocCall->getCalledFunction();
+ Assert1(GCRelocFn && GCRelocFn->isDeclaration() &&
+ (GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_result_int ||
+ GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_result_float ||
+ GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_result_ptr ||
+ GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_relocate),
+ "gc.result or gc.relocate are the only value uses of statepoint", &CI);
+ if (GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_result_int ||
+ GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_result_float ||
+ GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_result_ptr ) {
+ Assert1(GCRelocCall->getNumArgOperands() == 1, "wrong number of arguments", &CI);
+ Assert2(GCRelocCall->getArgOperand(0) == &CI, "connected to wrong statepoint", &CI, GCRelocCall);
+ } else if (GCRelocFn->getIntrinsicID() == Intrinsic::experimental_gc_relocate) {
+ Assert1(GCRelocCall->getNumArgOperands() == 3, "wrong number of arguments", &CI);
+ Assert2(GCRelocCall->getArgOperand(0) == &CI, "connected to wrong statepoint", &CI, GCRelocCall);
+ } else {
+ llvm_unreachable("unsupported use type - how'd we get past the assert?");
+ }
+ }
+
+ // Note: It is legal for a single derived pointer to be listed multiple
+ // times. It's non-optimal, but it is legal. It can also happen after
+ // insertion if we strip a bitcast away.
+ // Note: It is really tempting to check that each base is relocated and
+ // that a derived pointer is never reused as a base pointer. This turns
+ // out to be problematic since optimizations run after safepoint insertion
+ // can recognize equality properties that the insertion logic doesn't know
+ // about. See example statepoint.ll in the verifier subdirectory
+ break;
+ }
+ case Intrinsic::experimental_gc_result_int:
+ case Intrinsic::experimental_gc_result_float:
+ case Intrinsic::experimental_gc_result_ptr: {
+ Assert1(CI.getNumArgOperands() == 1, "wrong number of arguments", &CI);
+
+ // Are we tied to a statepoint properly?
+ CallSite StatepointCS(CI.getArgOperand(0));
+ const Function *StatepointFn = StatepointCS.getCalledFunction();
+ Assert2(StatepointFn && StatepointFn->isDeclaration() &&
+ StatepointFn->getIntrinsicID() == Intrinsic::experimental_gc_statepoint,
+ "token must be from a statepoint", &CI, CI.getArgOperand(0));
+ break;
}
+ case Intrinsic::experimental_gc_relocate: {
+ // Some checks to ensure gc.relocate has the correct set of
+ // parameters. TODO: we can make these tests much stricter.
+ Assert1(CI.getNumArgOperands() == 3, "wrong number of arguments", &CI);
+
+ // Are we tied to a statepoint properly?
+ CallSite StatepointCS(CI.getArgOperand(0));
+ const Function *StatepointFn =
+ StatepointCS.getInstruction() ? StatepointCS.getCalledFunction() : NULL;
+ Assert2(StatepointFn && StatepointFn->isDeclaration() &&
+ StatepointFn->getIntrinsicID() == Intrinsic::experimental_gc_statepoint,
+ "token must be from a statepoint", &CI, CI.getArgOperand(0));
+
+ // Both the base and derived must be piped through the safepoint
+ Value* Base = CI.getArgOperand(1);
+ Assert1( isa<ConstantInt>(Base), "must be integer offset", &CI);
+
+ Value* Derived = CI.getArgOperand(2);
+ Assert1( isa<ConstantInt>(Derived), "must be integer offset", &CI);
+
+ const int BaseIndex = cast<ConstantInt>(Base)->getZExtValue();
+ const int DerivedIndex = cast<ConstantInt>(Derived)->getZExtValue();
+ // Check the bounds
+ Assert1(0 <= BaseIndex &&
+ BaseIndex < (int)StatepointCS.arg_size(),
+ "index out of bounds", &CI);
+ Assert1(0 <= DerivedIndex &&
+ DerivedIndex < (int)StatepointCS.arg_size(),
+ "index out of bounds", &CI);
+ break;
+ }
+ };
}
void DebugInfoVerifier::verifyDebugInfo() {
OpenPOWER on IntegriCloud