diff options
| author | George Rimar <grimar@accesssoftek.com> | 2019-03-06 14:08:27 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2019-03-06 14:08:27 +0000 |
| commit | 5f0b7d2f468818659139240bf6425c007b994102 (patch) | |
| tree | 549387163f8230c85c1f5e0b6d2b9d8a237a2a97 /llvm/lib/IR/ModuleSummaryIndex.cpp | |
| parent | a2cc148f9fee10ff749a101975a23703e5460d0b (diff) | |
| download | bcm5719-llvm-5f0b7d2f468818659139240bf6425c007b994102.tar.gz bcm5719-llvm-5f0b7d2f468818659139240bf6425c007b994102.zip | |
[llvm-objcopy] - Remove an excessive zlib::isAvailable() check and dead code.
There are 2 places where llvm-objcopy creates CompressedSection:
For --compress-debug-sections. It might create the compressed section from
regular here:
https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-objcopy/ELF/ELFObjcopy.cpp#L486
All initially compressed sections are created as CompressedSection during reading the sections
from an object:
https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-objcopy/ELF/Object.cpp#L1118
Those have DebugCompressionType::None type and a different constructor.
Case 1 has the following code in its constructor:
if (!zlib::isAvailable()) {
CompressionType = DebugCompressionType::None;
return;
}
(https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-objcopy/ELF/Object.cpp#L267)
We can never reach that code with because would report an error much earlier:
https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-objcopy/CopyConfig.cpp#L480
So the code I am removing is dead. Landing this will address the issue mentioned in https://bugs.llvm.org/show_bug.cgi?id=40886.
Differential revision: https://reviews.llvm.org/D59019
llvm-svn: 355503
Diffstat (limited to 'llvm/lib/IR/ModuleSummaryIndex.cpp')
0 files changed, 0 insertions, 0 deletions

